fix(amplify-category-function): check for new function when adding permissions #8017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmissions it is handled as new function when function not found in amplify meta fix aws-amplify#7970
Codecov Report
@@ Coverage Diff @@
## master #8017 +/- ##
=======================================
Coverage 54.04% 54.04%
=======================================
Files 592 592
Lines 33380 33380
Branches 6917 6917
=======================================
Hits 18040 18040
Misses 14568 14568
Partials 772 772 Continue to review full report at Codecov.
|
jhockett
approved these changes
Aug 24, 2021
There was a problem hiding this comment.
LGTM, thanks for the contribution @fossamagna! I left two minor comments
...s__/provider-utils/awscloudformation/service-walkthroughs/execPermissionsWalkthrough.test.ts
Outdated
Show resolved
Hide resolved
...tion/src/provider-utils/awscloudformation/service-walkthroughs/execPermissionsWalkthrough.ts
Outdated
Show resolved
Hide resolved
…formation/service-walkthroughs/execPermissionsWalkthrough.ts Co-authored-by: John Hockett <jhockett@users.noreply.github.com>
jhockett
added a commit
that referenced
this pull request
Aug 25, 2021
…rmissions (#8017) * fix(amplify-category-function): check for new function when adding permissions it is handled as new function when function not found in amplify meta fix #7970 * test(amplify-category-function): remove unnecessary line * Update packages/amplify-category-function/src/provider-utils/awscloudformation/service-walkthroughs/execPermissionsWalkthrough.ts Co-authored-by: John Hockett <jhockett@users.noreply.github.com> Co-authored-by: John Hockett <jhockett@users.noreply.github.com>
|
👋 Hi, this pull request was referenced in the v5.4.0 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v5.4.0. |
github-actions
bot
added
the
referenced-in-release
marcvberg
pushed a commit
to marcvberg/amplify-cli
that referenced
this pull request
Oct 13, 2021
…rmissions (aws-amplify#8017) * fix(amplify-category-function): check for new function when adding permissions it is handled as new function when function not found in amplify meta fix aws-amplify#7970 * test(amplify-category-function): remove unnecessary line * Update packages/amplify-category-function/src/provider-utils/awscloudformation/service-walkthroughs/execPermissionsWalkthrough.ts Co-authored-by: John Hockett <jhockett@users.noreply.github.com> Co-authored-by: John Hockett <jhockett@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
A function attempting to add permissions is handled as new function when is not found in amplify meta.
Issue #, if available
fix #7970
Description of how you validated changes
yarn lerna --scope amplify-category-function run testChecklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.