Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move api utility isNameUnique to core as isResourceNameUnique #8038

Merged

Conversation

jhockett
Copy link
Contributor

Description of changes

move api utility isNameUnique() to amplify-cli-core as isResourceNameUnique() since it's a common use-case throughout the CLI

Description of how you validated changes

  • yarn test passes
  • successfully added, updated, and removed an api manually
  • added QGL api and attempted to add REST api with same name
? Provide a friendly name for your resource to be used as a label for this categ
ory in the project: api
>> A resource named 'api' already exists. Amplify resource names must be unique 
and are case-insensitive.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jhockett jhockett requested a review from a team as a code owner August 26, 2021 03:49
Copy link
Contributor

@attilah attilah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jhockett jhockett merged commit 8624305 into aws-amplify:master Sep 9, 2021
@jhockett jhockett deleted the isResourceNameUnique-refactor branch September 9, 2021 22:01
marcvberg pushed a commit to marcvberg/amplify-cli that referenced this pull request Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants