Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: version blocking for CLI" #8170

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Conversation

SwaySway
Copy link
Contributor

Reverts #7834

@SwaySway SwaySway requested a review from a team as a code owner September 13, 2021 23:56
@codecov-commenter
Copy link

Codecov Report

Merging #8170 (5cd2640) into master (50f07ef) will decrease coverage by 0.06%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8170      +/-   ##
==========================================
- Coverage   54.48%   54.42%   -0.07%     
==========================================
  Files         664      663       -1     
  Lines       37902    37834      -68     
  Branches     7788     7772      -16     
==========================================
- Hits        20650    20590      -60     
+ Misses      16412    16404       -8     
  Partials      840      840              
Impacted Files Coverage Δ
packages/amplify-cli-core/src/index.ts 100.00% <ø> (ø)
packages/amplify-cli/src/domain/context.ts 100.00% <ø> (ø)
...rovider-awscloudformation/src/aws-utils/aws-cfn.js 16.71% <0.00%> (+0.04%) ⬆️
...lify-provider-awscloudformation/src/initializer.ts 50.34% <ø> (-0.67%) ⬇️
...y-provider-awscloudformation/src/push-resources.ts 9.38% <0.00%> (+0.05%) ⬆️
packages/amplify-cli-core/src/errors/index.ts 100.00% <100.00%> (ø)
packages/amplify-cli/src/context-manager.ts 77.41% <100.00%> (+0.75%) ⬆️
packages/amplify-cli/src/index.ts 37.82% <100.00%> (+0.06%) ⬆️
packages/amplify-cli/src/version-notifier.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d43836f...5cd2640. Read the comment docs.

@SwaySway SwaySway merged commit f5a92e3 into master Sep 14, 2021
@github-actions
Copy link

👋 Hi, this pull request was referenced in the v5.6.0 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v5.6.0.

@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Sep 14, 2021
marcvberg pushed a commit to marcvberg/amplify-cli that referenced this pull request Oct 13, 2021
@aws-eddy aws-eddy deleted the revert-7834-versiongating branch February 10, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants