Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merges main branch to extOverrides #8357

Closed
wants to merge 31 commits into from

Conversation

akshbhu
Copy link
Contributor

@akshbhu akshbhu commented Oct 4, 2021

Description of changes

Merging master to extOverrides

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

aws-amplify-bot and others added 28 commits September 27, 2021 18:50
 - amplify-app@3.0.13
 - amplify-category-analytics@2.21.22
 - amplify-category-api@2.32.0
 - amplify-category-auth@2.38.2
 - amplify-category-function@2.35.0
 - amplify-category-geo@1.0.1
 - amplify-category-hosting@2.7.22
 - amplify-category-interactions@2.6.6
 - amplify-category-predictions@2.9.13
 - amplify-category-storage@2.12.10
 - amplify-category-xr@2.8.22
 - amplify-cli-core@1.30.0
 - @aws-amplify/cli@6.1.0
 - amplify-console-hosting@1.9.13
 - amplify-console-integration-tests@1.8.10
 - amplify-container-hosting@1.3.24
 - amplify-dotnet-function-template-provider@1.5.22
 - amplify-dynamodb-simulator@1.19.13
 - amplify-e2e-core@1.27.0
 - amplify-e2e-tests@2.51.0
 - amplify-frontend-ios@2.20.15
 - amplify-frontend-javascript@2.24.2
 - amplify-go-function-runtime-provider@1.9.5
 - @aws-amplify/graphql-function-transformer@0.4.4
 - @aws-amplify/graphql-http-transformer@0.5.4
 - @aws-amplify/graphql-index-transformer@0.3.3
 - @aws-amplify/graphql-model-transformer@0.6.3
 - @aws-amplify/graphql-predictions-transformer@0.3.4
 - @aws-amplify/graphql-relational-transformer@0.3.0
 - @aws-amplify/graphql-searchable-transformer@0.6.1
 - @aws-amplify/graphql-transformer-core@0.9.1
 - @aws-amplify/graphql-transformer-interfaces@1.9.1
 - amplify-java-function-runtime-provider@1.8.15
 - amplify-migration-tests@3.1.10
 - amplify-nodejs-function-runtime-provider@1.6.12
 - amplify-nodejs-function-template-provider@1.6.22
 - amplify-prompts@1.2.0
 - amplify-provider-awscloudformation@4.61.0
 - amplify-python-function-runtime-provider@1.9.12
 - amplify-util-import@1.5.13
 - amplify-util-mock@3.34.6
 - graphql-auth-transformer@6.24.23
 - graphql-connection-transformer@4.21.23
 - graphql-dynamodb-transformer@6.22.23
 - graphql-elasticsearch-transformer@4.12.2
 - graphql-function-transformer@2.5.22
 - graphql-http-transformer@4.18.10
 - graphql-key-transformer@2.23.23
 - graphql-predictions-transformer@2.5.22
 - graphql-relational-schema-transformer@2.18.7
 - graphql-transformer-common@4.19.10
 - graphql-transformer-core@6.30.0
 - graphql-transformers-e2e-tests@6.27.0
 - graphql-versioned-transformer@4.17.23
 - @aws-amplify/cli@6.1.1
 - amplify-console-integration-tests@1.8.11
 - amplify-e2e-core@1.27.1
 - amplify-e2e-tests@2.51.1
 - @aws-amplify/graphql-searchable-transformer@0.6.2
 - amplify-migration-tests@3.1.11
 - amplify-provider-awscloudformation@4.61.1
 - amplify-util-mock@3.34.7
 - graphql-auth-transformer@6.24.24
 - graphql-elasticsearch-transformer@4.12.3
 - graphql-transformers-e2e-tests@6.27.1
* feat: added root stack transformation

* feat: adding root-stack-builder

* feat: added e2e and migration tests

* fix: minor fixes

* fix: fixes unit tests

* fix: address comments
* feat: ddb overrides

* feat: add migration logic

* fix: remove older files post migration

* fix: address PR comments

* fix: remove inquirer and use amplify prompts instead

Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com>
@akshbhu akshbhu requested a review from a team as a code owner October 4, 2021 21:00
@akshbhu akshbhu force-pushed the extOverrdesMaster branch from b037810 to bc1c41f Compare October 5, 2021 02:07
@akshbhu akshbhu changed the title Ext overrdes master chore: merges main branch to extOverrides Oct 5, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #8357 (0f8e8d3) into extOverrides (89b4f0a) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           extOverrides    #8357   +/-   ##
=============================================
  Coverage         55.57%   55.57%           
=============================================
  Files               706      706           
  Lines             38998    38998           
  Branches           7865     7865           
=============================================
  Hits              21672    21672           
  Misses            16536    16536           
  Partials            790      790           
Impacted Files Coverage Δ
...chable-transformer/src/cdk/create-cfnParameters.ts 100.00% <ø> (ø)
...-awscloudformation/src/transform-graphql-schema.ts 12.12% <0.00%> (ø)
...graphql-elasticsearch-transformer/src/resources.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89b4f0a...0f8e8d3. Read the comment docs.

Copy link
Contributor

@kaustavghosh06 kaustavghosh06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on a high-level
just tow questions - please take a look and then merge.

@@ -306,156 +306,3 @@ describe('amplify add api (GraphQL)', () => {
// }
// });
});

describe('amplify add api (REST)', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason why we got rid of this?

@@ -115,54 +115,4 @@ describe('headless auth', () => {
const { auth: authBackendConfigAfter } = getCloudBackendConfig(projRoot);
expect(_.isEmpty(authBackendConfigAfter)).toBe(true);
});

describe(' import', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this test actually removed or just re-arranged?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its just re-arranged to reduce the no. of tests per file , I guess to reduce the time

@akshbhu
Copy link
Contributor Author

akshbhu commented Oct 14, 2021

closing as not needed

@akshbhu akshbhu closed this Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants