fix: auto migrate auth for headless flows #8735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhockett
approved these changes
Nov 8, 2021
...amplify-category-auth/src/provider-utils/awscloudformation/utils/check-for-auth-migration.ts
Show resolved
Hide resolved
kaustavghosh06
approved these changes
Nov 8, 2021
Codecov Report
@@ Coverage Diff @@
## extOverrides4 #8735 +/- ##
==============================================
Coverage 56.34% 56.34%
==============================================
Files 835 835
Lines 47255 47255
Branches 9477 9478 +1
==============================================
Hits 26624 26624
Misses 19813 19813
Partials 818 818
Continue to review full report at Codecov.
|
sachscode
pushed a commit
to sachscode/amplify-cli
that referenced
this pull request
Nov 10, 2021
sachscode
added a commit
that referenced
this pull request
Nov 10, 2021
* feat: FF for override stacks (#8228) * feat: root stack override (#8276) * feat: added root stack transformation * feat: adding root-stack-builder * feat: added e2e and migration tests * fix: minor fixes * fix: fixes unit tests * fix: address comments * feat: adding rootstack types to overrides helper package (#8298) * feat: ddb overrides and flow refactor * feat: ddb overrides * feat: add migration logic * fix: remove older files post migration * fix: address PR comments * fix: remove inquirer and use amplify prompts instead Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * chore: ddb walkthrough refactor and override tests (#8364) * chore: overrides ddb and walthrough refactor tests * chore: address pr comments Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * feat: Auth refactor to use cdk, eliminate EJS, overrides functionality (#8355) * feat: add auth override * fix: auth state unit tests working * feat: auth e2e fixes and migration e2e included * fix: fixes package name * fix: unit tests fix * fix: unit tests * fix: fixing overwritten files * fix: added vm2 and addressed comments * fix: minor fixes and e2e test for overrides * fix: cli-core unit test * fix: userPool group unit test * fix: minor refractor and comments * chore: lgtm warnings * fix: minor fixes * fix: unit tests * (feat) Override for S3 - ( includues refactor s3-walkthrough and migrate) (#8383) Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> * fix: fixes dependsOn parameter and auth migration test (#8480) * fix: dependsOn fix * chore: address comments * chore: remove JSON parsing * fix: default migration set to true * fix: added public access to scoped packages (#8485) * fix: adds typescript json dependency (#8487) * fix: enable scoped packages in plugin platform (#8492) * fix: adds userPool resourceName instead of authResource (#8497) * fix: adds userPool resourceName instead of authResource * fix: roleName in userPool groups * (bug-fix/reconcile-headless) remove groupList from userInputs, fix single-group, deploy errors (#8501) Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> * fix: userPool group template fixes (#8515) * fix: template and naming fixed * fix: addressed comments * (fix) Call Auth migration from S3 migration for all auth resources in S3 (#8511) * (fix) Call Auth migration from S3 migration for all auth resources used by S3 * (fix) use invokePluginMethod instead of direct category calls * (fix) unit-test for s3 migration Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> * (fix) s3 add with no-auth resource should succeed (#8520) Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> * (fix) amplify override storage fails with missing tsconfig.json (#8556) Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> * fix: parameters file path and updates cloud backend with build (#8564) * fix: latest changes * feat: define custom resources with CDK or CFN (#8590) * feat: define custom resources with CDK or CFN * chore: fix lint errors * chore: address API review and PR feedback * chore: fix unit test * fix: update skeleton CDK sample app based on API-Review * chore: fix build errors * chore: fix unit tests * chore: addressed PR review comments * chore: update uuid package version Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * chore: add public access for custom package * fix: add npmignore to custom resource package and update archiver (#8596) Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * fix: alias attr bug and use enabled mfa * fix: tsc global install error * fix: broken unit tests * fix: bug fixes in external auth enable * test: unit tests + e2e tests for custom resources (#8602) * test: unit tests for custom resources * chore: remove empty unit test file * fix: add all required types in override-helper package * chore: update override helper dependencies * test: unit test for dependency management utils * test: add coverage data and add more unit tests for cfn dependency management * test: add E2E tests for custom resources * chore: address PR review comments Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * fix: admin UI test * feat: add get project info helper to overrides helper package (#8620) * feat: add get project info helper to overrides helper package * chore: address PR feedback Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * chore: update skeleton package json override dependencies (#8641) Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * feat: amplify export * Refactor/packaging (#8547) * feat(amplify-provider-awscloudformation): refactor of the exporting resources * feat(amplify-provider-awscloudformation): refactored export to write files to external path * refactor: clean up * refactor: remove unused * fix: mispelled url * feat: fall back on push globing and template url * feat: export * feat: modify generation of lambda layer version content * fix(amplify-category-function): lambda layers filter stacks * feat: added command line for export * test(amplify-provider-awscloudformation): added tests for export resources * perf: removed unused * refactor: removed unused * fix: make the tags file pascal case * docs(amplify-provider-awscloudformation): added some documentation * feat(amplify-provider-awscloudformation): added warning and folder perms * fix: check in constants change * refactor: addressing PR feedback * refactor: es6 export * feat: minor changes for integration testing * refactor: pr comments * fix: cleared commented out code removed backup * ci: revert config file to main * Feat: export pull front end (#8488) * feat: export (#8486) * feat(amplify-provider-awscloudformation): refactor of the exporting resources * feat(amplify-provider-awscloudformation): refactored export to write files to external path * refactor: clean up * refactor: remove unused * fix: mispelled url * feat: fall back on push globing and template url * feat: export * feat: modify generation of lambda layer version content * fix(amplify-category-function): lambda layers filter stacks * feat: added command line for export * test(amplify-provider-awscloudformation): added tests for export resources * perf: removed unused * refactor: removed unused * fix: make the tags file pascal case * docs(amplify-provider-awscloudformation): added some documentation * feat(amplify-provider-awscloudformation): added warning and folder perms * fix: check in constants change * refactor: addressing PR feedback * refactor: es6 export * feat: minor changes for integration testing * refactor: pr comments * fix: cleared commented out code removed backup * ci: revert config file to main * feat: wip export pull * feat: amplify export pull to genereate front end config files * fix: merge fixes from export * refactor: removed unused * fix: some language fixes and bug fix with notification * test: e2e tests * test: codecov and test fix * Refactor/packaging (#8547) * feat(amplify-provider-awscloudformation): refactor of the exporting resources * feat(amplify-provider-awscloudformation): refactored export to write files to external path * refactor: clean up * refactor: remove unused * fix: mispelled url * feat: fall back on push globing and template url * feat: export * feat: modify generation of lambda layer version content * fix(amplify-category-function): lambda layers filter stacks * feat: added command line for export * test(amplify-provider-awscloudformation): added tests for export resources * perf: removed unused * refactor: removed unused * fix: make the tags file pascal case * docs(amplify-provider-awscloudformation): added some documentation * feat(amplify-provider-awscloudformation): added warning and folder perms * fix: check in constants change * refactor: addressing PR feedback * refactor: es6 export * feat: minor changes for integration testing * refactor: pr comments * fix: cleared commented out code removed backup * ci: revert config file to main * Feat: export pull front end (#8488) * feat: export (#8486) * feat(amplify-provider-awscloudformation): refactor of the exporting resources * feat(amplify-provider-awscloudformation): refactored export to write files to external path * refactor: clean up * refactor: remove unused * fix: mispelled url * feat: fall back on push globing and template url * feat: export * feat: modify generation of lambda layer version content * fix(amplify-category-function): lambda layers filter stacks * feat: added command line for export * test(amplify-provider-awscloudformation): added tests for export resources * perf: removed unused * refactor: removed unused * fix: make the tags file pascal case * docs(amplify-provider-awscloudformation): added some documentation * feat(amplify-provider-awscloudformation): added warning and folder perms * fix: check in constants change * refactor: addressing PR feedback * refactor: es6 export * feat: minor changes for integration testing * refactor: pr comments * fix: cleared commented out code removed backup * ci: revert config file to main * feat: wip export pull * feat: amplify export pull to genereate front end config files * fix: merge fixes from export * refactor: removed unused * fix: some language fixes and bug fix with notification * test: e2e tests * test: codecov and test fix * feat: export + override reconciled * test: fixed test because of bad merge * fix: added back conditional conditional rebuild * refactor(amplify-provider-awscloudformation): renamed the files to fit * test: fixed idp add storage test * test: fixes type import * feat: extensibility for REST APIs (#8598) * fix: ext overrides2 storage-headless and predictions (#8622) * fix: broken path on build-override * fix: pushing multiple APIs at a time (#8663) * fix: capitalization for filter, e2e test (#8667) * fix: capitalization for filter * test: fix prompt wait text * fix: test fixes (#8647) * (fix) add predictions + advanced mode + identifyEntity fails because … (#8658) * (fix) add predictions + advanced mode + identifyEntity fails because predictions cfn is not created * (fix) fixed regression for pred update + storage * (fix) plugininfo integ tests * (fix) storage e2e tests 'Auth' to 'Authenticated' Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> * fix: stack generation logic when multiple paths ref same Lambda (#8673) * Apigw revert (#8690) * Revert "fix: stack generation logic when multiple paths ref same Lambda (#8673)" This reverts commit fdbab02. * Revert "fix: capitalization for filter, e2e test (#8667)" This reverts commit e4f83fc. * Revert "fix: pushing multiple APIs at a time (#8663)" This reverts commit 4ff68bb. * Revert "fix: broken path on build-override" This reverts commit 712c043. * Revert "feat: extensibility for REST APIs (#8598)" This reverts commit 9822117. * (fix) [storage-1.test]init a project and add S3 bucket with user pool groups and then update S3 bucket to add trigger (#8691) Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> * (fix) storage unit-tests for prompter function change (#8693) Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> * fix: asana bug fixes (#8692) * fix: asana bug fixes * chore: removes commmented code * feat: overrides uniformity accross all the categories (#8695) * feat: overrides uniformity accross all the categories * chore: remove unneeded dependency * fix: apply override unformity to root-stack Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * Ext overrides3 storage headless migrate (#8696) * (fix) s3 cli-ux loop until permission selected * (fix) storage unit-tests for prompter function change * (fix) auto-migrate on headless s3 storage api * (fix) enable migration in headless only if required * (fix) unit-test failing because of path incorrect Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> * Ext overrides3 fix auth import s3 add (#8704) * (fix) add missing logic to validate auth requirements in storage * (fix) check for import auth * (fix) auth unit-tests couldnt find getImportedAuthProperties Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> * fix: fix configure project and custom policies api containers (#8703) * feat: add default descriptions to cfn templates for metrics tracking (#8702) * feat: add default descriptions to cfn temppaltes for metrics tracking * test: fix unit tests Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * fix: does not create build for ll (#8706) * test: fixing DDB E2E tests (#8707) * test: fixing DDB E2E tests * test: fix ddb import e2e test Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * fix: auth e2e tests (#8708) Co-authored-by: Ammar <56042290+ammarkarachi@users.noreply.github.com> * Consolidate types headless (#8698) * fix: consolidate types and auto migrate * fix: changed package name to extensiblity * fix: address comments * feat: consolidate dependent resource types in backend/ (#8709) * feat: consolidate dependent resource types in backend/ * chore: fix build.test.ts unit test Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * test: fix ddb import e2e tests (#8711) Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * Ext overrides3 fix storagee2es (#8715) * (fix) validate bucket name for headless * (fix) s3 e2e tests blocking because of singleSelect and multiSelect failure * (fix) s3 e2e tests blocking because of extraneous function selection prompt Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> * feat: change override.ts file to override.ts.sample in resources/ for pkg CLI to work (#8716) Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * fix: auth issue in export tests (#8710) * fix: auth issue in export tests * fix: address comments * Root stack fix (#8717) * fix: disable root stack update check * fix: root stack hash and helper package versions * (fix) graphql-schema predictions migration failure because of missing… (#8718) * (fix) graphql-schema predictions migration failure because of missing storage * (fix/cleanup) changed default for storage trigger to N, removed extraneous keydown Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> * fix: remove depending on conditional output variables from stacks (#8719) Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * fix: rebase conflicts * fix: auth e2e fixes * feat(amplify-cli-core): allow * in account and region in arn for custom policies (#8722) * fix(cli): fixed export pull command line (#8725) * fix: headless migrate auth (#8735) * Ext overrides4 storage e2e (#8740) * (fix) timeout in add lambda when lambda exists * (fix) override DDB StreamSpecification fails because of missing CFN * (fix) storage-5 build-overrides hang fix * (fix) storage-5.ts * (fix) help missing for storage overrides * (fix) storage_migration_update hangs * (fix) remove unintended ignoring of tests Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> * fix: migration test fixes (#8742) * fix: hooks + hosting e2e (#8743) * fix: hooks + hosting e2e * fix: address comments * test: update ignore pattern for build-tests, fix import ddb tests (#8744) * test(amplify-migration-tests): path fix for override-root file (#8745) * fix: update custom cdk seleton templates + format override skeleton file (#8752) * fix: update custom cdk seleton tempaltes + format override skeleton file * chore: revert package version chnge for cli-core Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * (fix) storage add walkthrough hanging in integ test (#8746) Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> * fix(amplify-category-auth): fixed the openId Connect proovider auth (#8753) * fix: fixed import_auth test (#8755) * fix: fixes auth migration e2e (#8756) * fix: fixes auth migration e2e * fix: signIn SignOut test * fix: remove no-override check for category transformations (#8765) Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * fix: init override test fix (#8768) * fix: amplify meta output for imported ddb, type fixes (#8767) * (fix) amplify status crashes when auth is legacy (#8769) Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> * fix: build resources on pull even with no override flag passed + update skeleton package.json (#8771) * fix: build resources on pull even with no override flag passed * chore: update package versions of ext helper in skeleton package.json + ci/cd fix * fix: build resource during initialzing an env Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * fix: generate dynamic amplify resource types before building cdk code (#8778) Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * fix: hosting fix and changelog added (#8780) * feat: FF for override stacks (#8228) * feat: root stack override (#8276) * feat: added root stack transformation * feat: adding root-stack-builder * feat: added e2e and migration tests * fix: minor fixes * fix: fixes unit tests * fix: address comments * feat: adding rootstack types to overrides helper package (#8298) * feat: ddb overrides and flow refactor * feat: ddb overrides * feat: add migration logic * fix: remove older files post migration * fix: address PR comments * fix: remove inquirer and use amplify prompts instead Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * chore: ddb walkthrough refactor and override tests (#8364) * chore: overrides ddb and walthrough refactor tests * chore: address pr comments Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * feat: Auth refactor to use cdk, eliminate EJS, overrides functionality (#8355) * feat: add auth override * fix: auth state unit tests working * feat: auth e2e fixes and migration e2e included * fix: fixes package name * fix: unit tests fix * fix: unit tests * fix: fixing overwritten files * fix: added vm2 and addressed comments * fix: minor fixes and e2e test for overrides * fix: cli-core unit test * fix: userPool group unit test * fix: minor refractor and comments * chore: lgtm warnings * fix: minor fixes * fix: unit tests * (feat) Override for S3 - ( includues refactor s3-walkthrough and migrate) (#8383) Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> * fix: fixes dependsOn parameter and auth migration test (#8480) * fix: dependsOn fix * chore: address comments * chore: remove JSON parsing * fix: default migration set to true * fix: added public access to scoped packages (#8485) * fix: adds typescript json dependency (#8487) * fix: enable scoped packages in plugin platform (#8492) * fix: adds userPool resourceName instead of authResource (#8497) * fix: adds userPool resourceName instead of authResource * fix: roleName in userPool groups * (bug-fix/reconcile-headless) remove groupList from userInputs, fix single-group, deploy errors (#8501) Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> * fix: userPool group template fixes (#8515) * fix: template and naming fixed * fix: addressed comments * (fix) Call Auth migration from S3 migration for all auth resources in S3 (#8511) * (fix) Call Auth migration from S3 migration for all auth resources used by S3 * (fix) use invokePluginMethod instead of direct category calls * (fix) unit-test for s3 migration Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> * (fix) s3 add with no-auth resource should succeed (#8520) Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> * (fix) amplify override storage fails with missing tsconfig.json (#8556) Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> * fix: parameters file path and updates cloud backend with build (#8564) * fix: latest changes * feat: define custom resources with CDK or CFN (#8590) * feat: define custom resources with CDK or CFN * chore: fix lint errors * chore: address API review and PR feedback * chore: fix unit test * fix: update skeleton CDK sample app based on API-Review * chore: fix build errors * chore: fix unit tests * chore: addressed PR review comments * chore: update uuid package version Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * chore: add public access for custom package * fix: add npmignore to custom resource package and update archiver (#8596) Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * fix: alias attr bug and use enabled mfa * fix: tsc global install error * fix: broken unit tests * fix: bug fixes in external auth enable * test: unit tests + e2e tests for custom resources (#8602) * test: unit tests for custom resources * chore: remove empty unit test file * fix: add all required types in override-helper package * chore: update override helper dependencies * test: unit test for dependency management utils * test: add coverage data and add more unit tests for cfn dependency management * test: add E2E tests for custom resources * chore: address PR review comments Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * fix: admin UI test * feat: add get project info helper to overrides helper package (#8620) * feat: add get project info helper to overrides helper package * chore: address PR feedback Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * chore: update skeleton package json override dependencies (#8641) Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * feat: amplify export * Refactor/packaging (#8547) * feat(amplify-provider-awscloudformation): refactor of the exporting resources * feat(amplify-provider-awscloudformation): refactored export to write files to external path * refactor: clean up * refactor: remove unused * fix: mispelled url * feat: fall back on push globing and template url * feat: export * feat: modify generation of lambda layer version content * fix(amplify-category-function): lambda layers filter stacks * feat: added command line for export * test(amplify-provider-awscloudformation): added tests for export resources * perf: removed unused * refactor: removed unused * fix: make the tags file pascal case * docs(amplify-provider-awscloudformation): added some documentation * feat(amplify-provider-awscloudformation): added warning and folder perms * fix: check in constants change * refactor: addressing PR feedback * refactor: es6 export * feat: minor changes for integration testing * refactor: pr comments * fix: cleared commented out code removed backup * ci: revert config file to main * Feat: export pull front end (#8488) * feat: export (#8486) * feat(amplify-provider-awscloudformation): refactor of the exporting resources * feat(amplify-provider-awscloudformation): refactored export to write files to external path * refactor: clean up * refactor: remove unused * fix: mispelled url * feat: fall back on push globing and template url * feat: export * feat: modify generation of lambda layer version content * fix(amplify-category-function): lambda layers filter stacks * feat: added command line for export * test(amplify-provider-awscloudformation): added tests for export resources * perf: removed unused * refactor: removed unused * fix: make the tags file pascal case * docs(amplify-provider-awscloudformation): added some documentation * feat(amplify-provider-awscloudformation): added warning and folder perms * fix: check in constants change * refactor: addressing PR feedback * refactor: es6 export * feat: minor changes for integration testing * refactor: pr comments * fix: cleared commented out code removed backup * ci: revert config file to main * feat: wip export pull * feat: amplify export pull to genereate front end config files * fix: merge fixes from export * refactor: removed unused * fix: some language fixes and bug fix with notification * test: e2e tests * test: codecov and test fix * Refactor/packaging (#8547) * feat(amplify-provider-awscloudformation): refactor of the exporting resources * feat(amplify-provider-awscloudformation): refactored export to write files to external path * refactor: clean up * refactor: remove unused * fix: mispelled url * feat: fall back on push globing and template url * feat: export * feat: modify generation of lambda layer version content * fix(amplify-category-function): lambda layers filter stacks * feat: added command line for export * test(amplify-provider-awscloudformation): added tests for export resources * perf: removed unused * refactor: removed unused * fix: make the tags file pascal case * docs(amplify-provider-awscloudformation): added some documentation * feat(amplify-provider-awscloudformation): added warning and folder perms * fix: check in constants change * refactor: addressing PR feedback * refactor: es6 export * feat: minor changes for integration testing * refactor: pr comments * fix: cleared commented out code removed backup * ci: revert config file to main * Feat: export pull front end (#8488) * feat: export (#8486) * feat(amplify-provider-awscloudformation): refactor of the exporting resources * feat(amplify-provider-awscloudformation): refactored export to write files to external path * refactor: clean up * refactor: remove unused * fix: mispelled url * feat: fall back on push globing and template url * feat: export * feat: modify generation of lambda layer version content * fix(amplify-category-function): lambda layers filter stacks * feat: added command line for export * test(amplify-provider-awscloudformation): added tests for export resources * perf: removed unused * refactor: removed unused * fix: make the tags file pascal case * docs(amplify-provider-awscloudformation): added some documentation * feat(amplify-provider-awscloudformation): added warning and folder perms * fix: check in constants change * refactor: addressing PR feedback * refactor: es6 export * feat: minor changes for integration testing * refactor: pr comments * fix: cleared commented out code removed backup * ci: revert config file to main * feat: wip export pull * feat: amplify export pull to genereate front end config files * fix: merge fixes from export * refactor: removed unused * fix: some language fixes and bug fix with notification * test: e2e tests * test: codecov and test fix * feat: export + override reconciled * test: fixed test because of bad merge * fix: added back conditional conditional rebuild * refactor(amplify-provider-awscloudformation): renamed the files to fit * test: fixed idp add storage test * test: fixes type import * feat: extensibility for REST APIs (#8598) * fix: ext overrides2 storage-headless and predictions (#8622) * fix: broken path on build-override * fix: pushing multiple APIs at a time (#8663) * fix: capitalization for filter, e2e test (#8667) * fix: capitalization for filter * test: fix prompt wait text * fix: test fixes (#8647) * (fix) add predictions + advanced mode + identifyEntity fails because … (#8658) * (fix) add predictions + advanced mode + identifyEntity fails because predictions cfn is not created * (fix) fixed regression for pred update + storage * (fix) plugininfo integ tests * (fix) storage e2e tests 'Auth' to 'Authenticated' Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> * fix: stack generation logic when multiple paths ref same Lambda (#8673) * Apigw revert (#8690) * Revert "fix: stack generation logic when multiple paths ref same Lambda (#8673)" This reverts commit fdbab02. * Revert "fix: capitalization for filter, e2e test (#8667)" This reverts commit e4f83fc. * Revert "fix: pushing multiple APIs at a time (#8663)" This reverts commit 4ff68bb. * Revert "fix: broken path on build-override" This reverts commit 712c043. * Revert "feat: extensibility for REST APIs (#8598)" This reverts commit 9822117. * (fix) [storage-1.test]init a project and add S3 bucket with user pool groups and then update S3 bucket to add trigger (#8691) Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> * (fix) storage unit-tests for prompter function change (#8693) Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> * fix: asana bug fixes (#8692) * fix: asana bug fixes * chore: removes commmented code * feat: overrides uniformity accross all the categories (#8695) * feat: overrides uniformity accross all the categories * chore: remove unneeded dependency * fix: apply override unformity to root-stack Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * Ext overrides3 storage headless migrate (#8696) * (fix) s3 cli-ux loop until permission selected * (fix) storage unit-tests for prompter function change * (fix) auto-migrate on headless s3 storage api * (fix) enable migration in headless only if required * (fix) unit-test failing because of path incorrect Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> * Ext overrides3 fix auth import s3 add (#8704) * (fix) add missing logic to validate auth requirements in storage * (fix) check for import auth * (fix) auth unit-tests couldnt find getImportedAuthProperties Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> * fix: fix configure project and custom policies api containers (#8703) * feat: add default descriptions to cfn templates for metrics tracking (#8702) * feat: add default descriptions to cfn temppaltes for metrics tracking * test: fix unit tests Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * fix: does not create build for ll (#8706) * test: fixing DDB E2E tests (#8707) * test: fixing DDB E2E tests * test: fix ddb import e2e test Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * fix: auth e2e tests (#8708) Co-authored-by: Ammar <56042290+ammarkarachi@users.noreply.github.com> * Consolidate types headless (#8698) * fix: consolidate types and auto migrate * fix: changed package name to extensiblity * fix: address comments * feat: consolidate dependent resource types in backend/ (#8709) * feat: consolidate dependent resource types in backend/ * chore: fix build.test.ts unit test Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * test: fix ddb import e2e tests (#8711) Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * Ext overrides3 fix storagee2es (#8715) * (fix) validate bucket name for headless * (fix) s3 e2e tests blocking because of singleSelect and multiSelect failure * (fix) s3 e2e tests blocking because of extraneous function selection prompt Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> * feat: change override.ts file to override.ts.sample in resources/ for pkg CLI to work (#8716) Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * fix: auth issue in export tests (#8710) * fix: auth issue in export tests * fix: address comments * Root stack fix (#8717) * fix: disable root stack update check * fix: root stack hash and helper package versions * (fix) graphql-schema predictions migration failure because of missing… (#8718) * (fix) graphql-schema predictions migration failure because of missing storage * (fix/cleanup) changed default for storage trigger to N, removed extraneous keydown Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> * fix: remove depending on conditional output variables from stacks (#8719) Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * fix: rebase conflicts * fix: auth e2e fixes * feat(amplify-cli-core): allow * in account and region in arn for custom policies (#8722) * fix(cli): fixed export pull command line (#8725) * fix: headless migrate auth (#8735) * Ext overrides4 storage e2e (#8740) * (fix) timeout in add lambda when lambda exists * (fix) override DDB StreamSpecification fails because of missing CFN * (fix) storage-5 build-overrides hang fix * (fix) storage-5.ts * (fix) help missing for storage overrides * (fix) storage_migration_update hangs * (fix) remove unintended ignoring of tests Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> * fix: migration test fixes (#8742) * fix: hooks + hosting e2e (#8743) * fix: hooks + hosting e2e * fix: address comments * test: update ignore pattern for build-tests, fix import ddb tests (#8744) * test(amplify-migration-tests): path fix for override-root file (#8745) * fix: update custom cdk seleton templates + format override skeleton file (#8752) * fix: update custom cdk seleton tempaltes + format override skeleton file * chore: revert package version chnge for cli-core Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * (fix) storage add walkthrough hanging in integ test (#8746) Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> * fix(amplify-category-auth): fixed the openId Connect proovider auth (#8753) * fix: fixed import_auth test (#8755) * fix: fixes auth migration e2e (#8756) * fix: fixes auth migration e2e * fix: signIn SignOut test * fix: remove no-override check for category transformations (#8765) Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * fix: init override test fix (#8768) * fix: amplify meta output for imported ddb, type fixes (#8767) * (fix) amplify status crashes when auth is legacy (#8769) Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> * fix: build resources on pull even with no override flag passed + update skeleton package.json (#8771) * fix: build resources on pull even with no override flag passed * chore: update package versions of ext helper in skeleton package.json + ci/cd fix * fix: build resource during initialzing an env Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * fix: generate dynamic amplify resource types before building cdk code (#8778) Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> * fix: hosting fix and changelog added (#8780) * Fix/export pull e2e 2 (#8785) * test(amplify-e2e-tests): adding a setting * test(amplify-e2e-core): testlambda with latest codebase Co-authored-by: akshbhu <39866697+akshbhu@users.noreply.github.com> Co-authored-by: Kaustav Ghosh <kaustav.ghosh19@gmail.com> Co-authored-by: Ghosh <kaustavg@3c22fb229ff6.ant.amazon.com> Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> Co-authored-by: Akshay <akshayupadhyay3@gmail.com> Co-authored-by: Ammar <56042290+ammarkarachi@users.noreply.github.com> Co-authored-by: John Hockett <jhockett@users.noreply.github.com> Co-authored-by: jhockett <johocke@amazon.com>
sachscode
pushed a commit
to sachscode/amplify-cli
that referenced
this pull request
Nov 10, 2021
sachscode
pushed a commit
that referenced
this pull request
Nov 11, 2021
sachscode
pushed a commit
to sachscode/amplify-cli
that referenced
this pull request
Nov 11, 2021
kaustavghosh06
pushed a commit
that referenced
this pull request
Nov 11, 2021
akshbhu
added a commit
to akshbhu/amplify-cli
that referenced
this pull request
Nov 11, 2021
ammarkarachi
pushed a commit
that referenced
this pull request
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.