fix: do not update idp if credentials not present #9454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
reviewed
Jan 7, 2022
packages/amplify-category-auth/resources/auth-custom-resource/hostedUIProviderLambda.js
Outdated
Show resolved
Hide resolved
...r-utils/awscloudformation/auth-stack-builder/__snapshots__/auth-stack-transform.test.ts.snap
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #9454 +/- ##
=======================================
Coverage 52.62% 52.62%
=======================================
Files 821 821
Lines 45551 45551
Branches 9729 9729
=======================================
Hits 23973 23973
Misses 19577 19577
Partials 2001 2001 Continue to review full report at Codecov.
|
jhockett
approved these changes
Jan 20, 2022
|
@jhockett I can add one |
|
Going to hold off on merging this for now, pending the requested test. |
ammarkarachi
force-pushed
the
fix/hostedui-pull
branch
from
8def800 to
49470bd
Compare
cjihrig
approved these changes
Feb 3, 2022
|
👋 Hi, this pull request was referenced in the v7.6.19 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.19. |
github-actions
bot
added
the
referenced-in-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
On a pull when and then executing another push the auth the idp updater/creator custom lambda resource throws an error since the credentials do not exist
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.