fix: rest api policy size calculation #9576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
yuth
changed the title
jhockett
reviewed
Jan 26, 2022
Codecov Report
@@ Coverage Diff @@
## master #9576 +/- ##
==========================================
+ Coverage 52.76% 52.88% +0.12%
==========================================
Files 821 821
Lines 45576 45580 +4
Branches 9731 9732 +1
==========================================
+ Hits 24049 24107 +58
+ Misses 19531 19477 -54
Partials 1996 1996
Continue to review full report at Codecov.
|
cjihrig
approved these changes
Jan 27, 2022
| @@ -16,16 +16,38 @@ import * as fs from 'fs-extra'; | |||
| import * as path from 'path'; | |||
| import { ProviderName } from '../constants'; | |||
|
|
|||
| // type information from input schema located at packages/amplify-category-api/resources/schemas/aPIGateway/APIGatewayCLIInputs.schema.json | |||
@cjihrig In this test I am adding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Change REST API policy size calculation logic and numbers. The resource gets collapsed into a single resource with
*when all the HTTP verbs are allowed for a path.Issue #, if available
N/A
Description of how you validated changes
Manual deployments
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.