Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve function templates; consolidate console.log, add jsdoc, add lambda types #9649

Merged
merged 3 commits into from
Feb 3, 2022
Merged

feat: improve function templates; consolidate console.log, add jsdoc, add lambda types #9649

merged 3 commits into from
Feb 3, 2022

Conversation

josefaidt
Copy link
Contributor

@josefaidt josefaidt commented Jan 29, 2022

Description of changes

  • consolidates provided console.log structure
  • add JSDoc annotations
  • add Lambda Types package for JSDoc

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2022

Codecov Report

Merging #9649 (cfe9de5) into master (63c09ad) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9649   +/-   ##
=======================================
  Coverage   52.93%   52.93%           
=======================================
  Files         829      829           
  Lines       45865    45865           
  Branches     9789     9789           
=======================================
  Hits        24279    24279           
  Misses      19581    19581           
  Partials     2005     2005           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63c09ad...cfe9de5. Read the comment docs.

Copy link
Contributor

@jhockett jhockett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josefaidt josefaidt marked this pull request as ready for review January 31, 2022 19:44
@josefaidt josefaidt requested a review from a team as a code owner January 31, 2022 19:44
@ammarkarachi ammarkarachi merged commit 5b24455 into aws-amplify:master Feb 3, 2022
@github-actions
Copy link

👋 Hi, this pull request was referenced in the v7.6.19 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.19.

@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Feb 10, 2022
@josefaidt josefaidt linked an issue Feb 10, 2022 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated index.js for Cognito triggers is missing context & callback params
4 participants