Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: print recorded screen frames when nextpect times out in E2E tests #9664

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

yuth
Copy link
Contributor

@yuth yuth commented Feb 1, 2022

Description of changes

When E2E tests timeout in nexpect, to see the error one has to play the entire asciinema by loading the test report page from the artifact section. Updating the timeout error message to include the few lines of screen recording to surface it in the exception

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yuth yuth requested a review from a team as a code owner February 1, 2022 00:36
@codecov-commenter
Copy link

Codecov Report

Merging #9664 (1e81e58) into master (4a87373) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9664   +/-   ##
=======================================
  Coverage   52.93%   52.93%           
=======================================
  Files         829      829           
  Lines       45865    45865           
  Branches     9789     9789           
=======================================
  Hits        24279    24279           
  Misses      19581    19581           
  Partials     2005     2005           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a87373...1e81e58. Read the comment docs.

@ammarkarachi ammarkarachi merged commit f301220 into aws-amplify:master Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants