fix: separate out subscription errors from field level resolver generation #9671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammarkarachi
approved these changes
Feb 1, 2022
jhockett
reviewed
Feb 1, 2022
packages/amplify-cli/src/extensions/amplify-helpers/auth-notifications.ts
Outdated
Show resolved
Hide resolved
packages/amplify-cli/src/extensions/amplify-helpers/auth-notifications.ts
Show resolved
Hide resolved
packages/amplify-cli/src/extensions/amplify-helpers/auth-notifications.ts
Outdated
Show resolved
Hide resolved
SwaySway
approved these changes
Feb 1, 2022
packages/amplify-cli/src/extensions/amplify-helpers/auth-notifications.ts
Outdated
Show resolved
Hide resolved
packages/amplify-cli/src/extensions/amplify-helpers/auth-notifications.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #9671 +/- ##
==========================================
- Coverage 52.93% 52.90% -0.04%
==========================================
Files 829 830 +1
Lines 45865 45948 +83
Branches 9789 9812 +23
==========================================
+ Hits 24279 24308 +29
- Misses 19581 19628 +47
- Partials 2005 2012 +7
Continue to review full report at Codecov.
|
danielleadams
force-pushed
the
da/fix-non-null-auth
branch
from
dda5cf2 to
90394e9
Compare
undefobj
approved these changes
Feb 1, 2022
lazpavel
suggested changes
Feb 1, 2022
packages/amplify-cli/src/extensions/amplify-helpers/auth-notifications.ts
Outdated
Show resolved
Hide resolved
lazpavel
reviewed
Feb 1, 2022
packages/amplify-cli/src/extensions/amplify-helpers/auth-notifications.ts
Show resolved
Hide resolved
danielleadams
force-pushed
the
da/fix-non-null-auth
branch
from
90394e9 to
720b434
Compare
|
This pull request introduces 1 alert when merging 720b434 into ff70827 - view on LGTM.com new alerts:
|
lazpavel
approved these changes
Feb 1, 2022
danielleadams
force-pushed
the
da/fix-non-null-auth
branch
from
720b434 to
767cd4c
Compare
|
This pull request introduces 1 alert when merging 767cd4c into ff70827 - view on LGTM.com new alerts:
|
|
👋 Hi, this pull request was referenced in the v7.6.15 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.15. |
github-actions
bot
added
the
referenced-in-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This pull requests separates out generation of field-level resolvers from checking for errors on types with subscriptions configured.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.