fix: fix modify gql schema base case; scope auth notif to v2 #9689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 1 alert when merging 854a71d into 5ff6fe8 - view on LGTM.com fixed alerts:
|
ammarkarachi
reviewed
Feb 3, 2022
| if (stats.isDirectory()) { | ||
| await modifyGraphQLSchemaDirectory(fullPath, modified); | ||
| } else if (stats.isFile() && !modified) { | ||
| if (stats.isDirectory() && (await modifyGraphQLSchemaDirectory(fullPath))) { |
There was a problem hiding this comment.
Suggested change
| if (stats.isDirectory() && (await modifyGraphQLSchemaDirectory(fullPath))) { | |
| if ((await modifyGraphQLSchemaDirectory(fullPath))) { | |
| if(stats.isFile()){ | |
| fs.appendFile(fullPath, ' '); | |
| } | |
| return true; | |
| } |
There was a problem hiding this comment.
not sure if this will work, this will attempt to read files from a non directory
There was a problem hiding this comment.
yeah never mind I was thinking about it wrong
lazpavel
approved these changes
Feb 3, 2022
| if (stats.isDirectory()) { | ||
| await modifyGraphQLSchemaDirectory(fullPath, modified); | ||
| } else if (stats.isFile() && !modified) { | ||
| if (stats.isDirectory() && (await modifyGraphQLSchemaDirectory(fullPath))) { |
There was a problem hiding this comment.
not sure if this will work, this will attempt to read files from a non directory
ammarkarachi
approved these changes
Feb 3, 2022
|
👋 Hi, this pull request was referenced in the v7.6.19 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.19. |
github-actions
bot
added
the
referenced-in-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.