ci: Speed up bootstrap #3317
Merged
ci: Speed up bootstrap #3317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjnoyp
reviewed
Jun 28, 2023
| @@ -88,7 +88,17 @@ const amplifyEnvironments = <String, String>{}; | |||
| [for (final package in bootstrapPackages) _createEmptyConfig(package)], | |||
| ); | |||
| if (build) { | |||
| for (final package in bootstrapPackages) { | |||
| // Packages which must be built because they vendor assets required for | |||
There was a problem hiding this comment.
Vendor is a verb here
fjnoyp
reviewed
Jun 28, 2023
| @@ -88,7 +88,17 @@ const amplifyEnvironments = <String, String>{}; | |||
| [for (final package in bootstrapPackages) _createEmptyConfig(package)], | |||
| ); | |||
| if (build) { | |||
| for (final package in bootstrapPackages) { | |||
| // Packages which must be built because they vendor assets required for | |||
| // running all downstream packages. | |||
There was a problem hiding this comment.
nit: Comment should be capitalized
fjnoyp
approved these changes
Jun 28, 2023
Equartey
approved these changes
Jun 28, 2023
ragingsquirrel3
pushed a commit
that referenced
this pull request
Jul 6, 2023
* ci: Speed up bootstrap * Fix example * More fixes * Clean up * Fixes * Clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces
aft bootstraptime in CI by only bootstrapping necessary packages.This improves average workflow speed by 80-90% (seriously quick now!) and should help flakiness since we're no longer DDoS'ing pub as bad in our workflows.