feat(logging): add new aws_logging_cloudwatch package and generate cloudwatch sdk #3441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnys1
reviewed
Jul 19, 2023
|
|
||
| dev_dependencies: | ||
| amplify_lints: ^2.0.0 | ||
| build_runner: ^2.0.0 |
There was a problem hiding this comment.
Can you run aft constraints apply?
Comment on lines
4
to
5
| - com.amazonaws.cloudwatchlogs#DescribeLogGroups | ||
| - com.amazonaws.cloudwatchlogs#DescribeLogStreams |
There was a problem hiding this comment.
Are these needed in the main pkg or just for tests?
There was a problem hiding this comment.
they maybe needed for the main pkg, depends if we need to call DescribeLogGroups/DescribeLogStreams to check if they exists. I think it is best to remove them now and we add when we are sure we need them.
dnys1
approved these changes
Jul 19, 2023
Jordan-Nelson
approved these changes
Jul 21, 2023
NikaHsn
added a commit
that referenced
this pull request
Aug 2, 2023
…oudwatch sdk (#3441) * add a new dart package with aft create * add cloudwatch sdk * update dependencies constraint in pubspec files * update sdk.yaml file to remove unused apis
khatruong2009
pushed a commit
to khatruong2009/amplify-flutter
that referenced
this pull request
Aug 3, 2023
…oudwatch sdk (aws-amplify#3441) * add a new dart package with aft create * add cloudwatch sdk * update dependencies constraint in pubspec files * update sdk.yaml file to remove unused apis
khatruong2009
pushed a commit
to khatruong2009/amplify-flutter
that referenced
this pull request
Aug 18, 2023
…oudwatch sdk (aws-amplify#3441) * add a new dart package with aft create * add cloudwatch sdk * update dependencies constraint in pubspec files * update sdk.yaml file to remove unused apis
khatruong2009
pushed a commit
that referenced
this pull request
Nov 27, 2023
…oudwatch sdk (#3441) * add a new dart package with aft create * add cloudwatch sdk * update dependencies constraint in pubspec files * update sdk.yaml file to remove unused apis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
setup a new package for cloudwatch logging:
P.S. sdk.yaml file is manually added, pubspec.yaml is updated, and rest are autogenerated codes.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.