Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(logging): fixed comment for static method and export #3631

Merged
merged 4 commits into from
Aug 29, 2023

Conversation

khatruong2009
Copy link
Member

@khatruong2009 khatruong2009 commented Aug 28, 2023

Issue #, if available:

Description of changes:

  • fixed comment for static method
  • bumped versions for dependencies
  • updated a test to prevent timeout and make it more efficient

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@khatruong2009 khatruong2009 requested a review from a team as a code owner August 28, 2023 22:09
@NikaHsn NikaHsn force-pushed the feat/logging/cloudwatch branch from 1221333 to 123df2e Compare August 29, 2023 17:50
@khatruong2009 khatruong2009 changed the title chore(logging): fixed comment for static method chore(logging): fixed comment for static method and export Aug 29, 2023
@khatruong2009 khatruong2009 merged commit 1c0d2dc into feat/logging/cloudwatch Aug 29, 2023
@khatruong2009 khatruong2009 deleted the feat/logging/comment branch August 30, 2023 16:22
khatruong2009 added a commit that referenced this pull request Nov 27, 2023
* fixed comment for static method

* fix: updated versions with aft and added back in queuedItemStorage exports (not sure how it got removed)

* fix: made tests more efficient so it wouldn't time out and removed a default todo comment

* chore: changed package_info_plus back to ^4.0.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants