chore: remove delay to start datastore in tests #3738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jordan-Nelson
force-pushed
the
feat/remove-ds-timeout
branch
3 times, most recently
from
8e432a3 to
91efb1e
Compare
Jordan-Nelson
force-pushed
the
feat/remove-ds-timeout
branch
from
5fd8538 to
91a1999
Compare
Jordan-Nelson
changed the title
Jordan-Nelson
commented
Sep 14, 2023
| @@ -22,7 +22,7 @@ void main() { | |||
| await Amplify.DataStore.save(blog); | |||
| var resultOne = await Amplify.DataStore.query(Blog.classType); | |||
| expect(resultOne, isNotEmpty); | |||
| await Amplify.DataStore.clear(); | |||
| await clearDataStore(); | |||
There was a problem hiding this comment.
clearDataStore(); adds a delay before calling clear, which is still needed since this test calls clear and then start multiple times in a row.
Equartey
approved these changes
Sep 14, 2023
dnys1
approved these changes
Sep 14, 2023
fjnoyp
pushed a commit
that referenced
this pull request
Sep 21, 2023
chore: remove start delay is datastore tests
fjnoyp
pushed a commit
that referenced
this pull request
Sep 21, 2023
chore: remove start delay is datastore tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
See passing test run (with all the cloud sync tests running): https://github.com/aws-amplify/amplify-flutter/actions/runs/6188100758/job/16799548931?pr=3738
Note: As mentioned in aws-amplify/amplify-android#1690 (comment), and aws-amplify/amplify-android#1464, calling stop and then start multiple times in a row, or calling stop/clear multiple times in a row will still result in issues.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.