chore(actions): Fixes for upcoming Dart changes #3742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dnys1
commented
Sep 14, 2023
dnys1
commented
- Ensures that JS interop methods use only interop values for inputs/outputs.
- Prefers Dart primitives (String, bool, int) over JS primitives (JSString, etc.) since newer Dart enables automatic conversion.
dnys1
force-pushed
the
chore/actions-improvements
branch
from
352fa30 to
a69e197
Compare
- Ensures that JS interop methods use only interop values for inputs/outputs. - Prefers Dart primitives (String, bool, int) over JS primitives (JSString, etc.) since newer Dart enables automatic conversion.
dnys1
force-pushed
the
chore/actions-improvements
branch
from
a69e197 to
a5aeba2
Compare
Jordan-Nelson
approved these changes
Sep 19, 2023
fjnoyp
approved these changes
Sep 21, 2023
fjnoyp
pushed a commit
that referenced
this pull request
Sep 21, 2023
- Ensures that JS interop methods use only interop values for inputs/outputs. - Prefers Dart primitives (String, bool, int) over JS primitives (JSString, etc.) since newer Dart enables automatic conversion.
fjnoyp
pushed a commit
that referenced
this pull request
Sep 21, 2023
- Ensures that JS interop methods use only interop values for inputs/outputs. - Prefers Dart primitives (String, bool, int) over JS primitives (JSString, etc.) since newer Dart enables automatic conversion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.