chore!: remove deprecated auth types #4764
Conversation
Jordan-Nelson
force-pushed
the
chore/auth/remove-deprecated-types
branch
from
8d66d80 to
e975914
Compare
| /// The default flow used to sign in. | ||
| late final AuthFlowType defaultAuthFlowType = () { | ||
| // Get the flow from the plugin config | ||
| final pluginFlowType = | ||
| expect<CognitoPluginConfig>().auth?.default$?.authenticationFlowType ?? | ||
| AuthenticationFlowType.userSrpAuth; | ||
| return pluginFlowType.sdkValue; | ||
| }(); | ||
|
|
There was a problem hiding this comment.
I acknowledge that this field is not present in CLI Gen2. However, with these modifications, we are bypassing the configuration value for users who are still using CLI Gen1.
There was a problem hiding this comment.
That is correct. Customers can specify this via SignInOptions though.
The current behavior is to use the value from SignInOptions if it exists. If not, use the value from the config if it exists. If neither exist, AuthenticationFlowType.userSrpAuth is the default.
The new behavior is to use the value from SignInOptions if it exists. If not, AuthenticationFlowType.userSrpAuth is the default.
It is a breaking change that will be called out in the change log for v2.
There was a problem hiding this comment.
I think we may need to add a note in our Gen1/V2 documentation indicating the value from the configuration file is not used by the library. Instead, users should use the SignInOptions.
There was a problem hiding this comment.
Agreed. I meant to say this will be called out in the migration guide
Jordan-Nelson
force-pushed
the
chore/auth/remove-deprecated-types
branch
from
c67ed08 to
c99eb94
Compare
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.