feat(storage): update s3 storage service to support multiple s3 client for multi-bucket support #5493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t for multi-bucket support
ekjotmultani
approved these changes
Sep 24, 2024
Equartey
reviewed
Sep 25, 2024
Comment on lines
29
to
43
| orElse: () => throw const InvalidStorageBucketException( | ||
| 'Unable to lookup bucket from provided name in Amplify Outputs file.', | ||
| recoverySuggestion: 'Make sure Amplify Outputs file has the specified ' | ||
| 'bucket configuration.', | ||
| ), | ||
| ); | ||
| if (bucket == null) { | ||
| throw const InvalidStorageBucketException( | ||
| 'Amplify Outputs storage configuration does not have buckets specified.', | ||
| recoverySuggestion: | ||
| 'Make sure Amplify Outputs file has storage configuration with ' | ||
| 'buckets specified.', | ||
| ); | ||
| } | ||
| return BucketInfo(bucketName: bucket.bucketName, region: bucket.awsRegion); |
There was a problem hiding this comment.
nit suggestion: Perform the null check before accessing storageOutputs.buckets.singleWhere. I initially overlooked the optional chaining, which made orElse appear redundant upon first glance.
Comment on lines
+5
to
+6
| @internal | ||
| class S3ClientInfo { |
Equartey
approved these changes
Sep 25, 2024
tyllark
approved these changes
Sep 25, 2024
ekjotmultani
pushed a commit
that referenced
this pull request
Oct 18, 2024
…t for multi-bucket support (#5493)
NikaHsn
added a commit
that referenced
this pull request
Oct 23, 2024
…t for multi-bucket support (#5493)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.