Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/authenticator/phone validator #5511

Closed
wants to merge 2 commits into from

Conversation

ekjotmultani
Copy link
Member

Issue #, if available: #4079

Description of changes:

  • Drop the country code prefix before performing validation
    This is done in the exact same way as this rolled back fix from November last year. This fix was correct for the main issue in the original issue however it didn't address being able to re-input a dial code and still have it pass through validation

  • Truncate a re-inputted dial code if it exceeds the maximum length of a phone number from that given country
    Using a map of dial codes to their countries' maximum length of phone number (generated from https://github.com/google/libphonenumber/tree/master), we will check if the inputted phone number begins with the selected dial code, if it does, then check if it surpasses the length of number in that country (since it could be the case that the number naturally begins with the dial code), if this is also true then ignore the repeat dial code and take the leftover number as the phone number

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ekjotmultani ekjotmultani requested a review from a team as a code owner September 30, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant