fix(common): added a flag to opt out of bundling sqlite3 for windows apps #5680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Equartey
changed the title
tyllark
approved these changes
Nov 21, 2024
Equartey
changed the title
NikaHsn
approved these changes
Nov 25, 2024
Equartey
added a commit
that referenced
this pull request
Nov 25, 2024
Equartey
added a commit
that referenced
this pull request
Nov 25, 2024
### Fixes - fix(authenticator): recover from exceptions during reset password flow ([#5672](#5672)) - fix(common): added a flag to opt out of bundling sqlite3 for windows apps ([#5680](#5680)) - fix(storage): Only allow 1 batch to run at a time ([#5704](#5704)) Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Equartey
added a commit
that referenced
this pull request
Nov 25, 2024
### Fixes - fix(authenticator): recover from exceptions during reset password flow ([#5672](#5672)) - fix(common): added a flag to opt out of bundling sqlite3 for windows apps ([#5680](#5680)) - fix(storage): Only allow 1 batch to run at a time ([#5704](#5704)) Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Equartey
added a commit
that referenced
this pull request
Nov 26, 2024
Equartey
added a commit
that referenced
this pull request
Nov 26, 2024
### Fixes - fix(authenticator): recover from exceptions during reset password flow ([#5672](#5672)) - fix(common): added a flag to opt out of bundling sqlite3 for windows apps ([#5680](#5680)) - fix(storage): Only allow 1 batch to run at a time ([#5704](#5704)) Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Equartey
added a commit
that referenced
this pull request
Nov 26, 2024
### Fixes - fix(authenticator): recover from exceptions during reset password flow ([#5672](#5672)) - fix(common): added a flag to opt out of bundling sqlite3 for windows apps ([#5680](#5680)) - fix(storage): Only allow 1 batch to run at a time ([#5704](#5704)) Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#5477
Description of changes:
Adds a flag for a consuming App to opt out of having Amplify DB Common bundle sqlite3 at build time. This avoids name collisions when a downstream app includes
sqlite3which is globally defined. Even when the flag isON, amplify is able to find and use the dependency.Usage:
Paste the following near the top of
your_project/windows/CMakeLists.txtto opt out of amplify buildingsqlite3for windows. Example is also shown in files changed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.