-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added additional Auth config fields & ability to override Cognito endpoint. #12236
Merged
jimblanc
merged 10 commits into
aws-amplify:next/main
from
jimblanc:feat/ui-config-changes
Oct 10, 2023
Merged
feat: Added additional Auth config fields & ability to override Cognito endpoint. #12236
jimblanc
merged 10 commits into
aws-amplify:next/main
from
jimblanc:feat/ui-config-changes
Oct 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…js into feat/ui-config-changes
…js into feat/ui-config-changes
thaddmt
approved these changes
Oct 9, 2023
elorzafe
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Thanks @jimblanc
ioanabrooks
approved these changes
Oct 9, 2023
AllanZhengYP
reviewed
Oct 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I only have 1 comment.
Samaritan1011001
pushed a commit
to Samaritan1011001/amplify-js
that referenced
this pull request
Oct 10, 2023
Open
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This change adds additional fields to the Auth config required by the UI team and updates
parseAWSExports
as appropriate. It also enables the ability to provide a custom Cognito endpoint URL viaendpoint
.Issue #, if available
Description of how you validated changes
Local testing in sample apps.
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.