Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added additional Auth config fields & ability to override Cognito endpoint. #12236

Merged
merged 10 commits into from
Oct 10, 2023

Conversation

jimblanc
Copy link
Contributor

@jimblanc jimblanc commented Oct 9, 2023

Description of changes

This change adds additional fields to the Auth config required by the UI team and updates parseAWSExports as appropriate. It also enables the ability to provide a custom Cognito endpoint URL via endpoint.

Issue #, if available

Description of how you validated changes

Local testing in sample apps.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jimblanc jimblanc marked this pull request as ready for review October 9, 2023 21:25
@jimblanc jimblanc requested review from a team as code owners October 9, 2023 21:25
Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Thanks @jimblanc

Copy link
Member

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I only have 1 comment.

packages/core/src/singleton/Auth/types.ts Show resolved Hide resolved
@jimblanc jimblanc merged commit 6060984 into aws-amplify:next/main Oct 10, 2023
24 checks passed
Samaritan1011001 pushed a commit to Samaritan1011001/amplify-js that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants