Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove integ_vue_auth_legacy_vue_authenticator failing canary test #12657

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

kvramyasri7
Copy link
Contributor

Description of changes

  • Removing integ_vue_auth_legacy_vue_authenticator as it needs 0'ver-Engineering.

Issue #, if available

integ_vue_auth_legacy_vue_authenticator workflow πŸƒβ€β™€οΈ

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kvramyasri7 kvramyasri7 requested a review from a team as a code owner November 30, 2023 21:17
@kvramyasri7 kvramyasri7 changed the title chore: remove integ_vue_auth_legacy_vue_authenticator failing canary test Fix: remove integ_vue_auth_legacy_vue_authenticator failing canary test Nov 30, 2023
…ssr_page` tests fix (aws-amplify#12655)

fix: Build Sample App Tests and integ_next_auth_authenticator_and_ssr_page tests
@kvramyasri7 kvramyasri7 changed the title Fix: remove integ_vue_auth_legacy_vue_authenticator failing canary test Fix: remove integ_vue_auth_legacy_vue_authenticator failing canary test Nov 30, 2023
Copy link
Member

@ashwinkumar6 ashwinkumar6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently disabled on e2e, makes sense to remove this from canary for now

Thanks @kvramyasri7 lgtm

@kvramyasri7 kvramyasri7 requested a review from cshfang November 30, 2023 22:00
@kvramyasri7 kvramyasri7 merged commit eb3a036 into aws-amplify:main Nov 30, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants