Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(auth): debounce refreshAuthTokens #12845
chore(auth): debounce refreshAuthTokens #12845
Changes from 6 commits
4b27260
751b15b
80c2b60
4ab0de2
b0d982a
3419b8f
4bbeba0
e3df8aa
0db3893
a717e20
b46967d
4ce72c3
1444ffd
a976d76
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test may not be accurate - the
mockServiceCallback
called times should increase after the promised returned by it resolves, and whendebouncedCallback
gets called again, but in this test, themockServiceCallback
doesn't even return a promise.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the
mockServiceCallback
doesn't return a promise but thedeDupe
function does because it creates a promise on top of thecallback
passed. What I'm trying to do is to call thedeDuped
function concurrently and then calling it again when it was able to resolve.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😬