-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add PR title check workflow #13872
base: main
Are you sure you want to change the base?
Conversation
8efc2a5
to
9bcfaa5
Compare
9bcfaa5
to
f014b03
Compare
scopes=$(ls -d ./packages/*/ 2>/dev/null | xargs -n 1 basename | tr '\n' '|' | sed 's/|$//') | ||
|
||
# Generate the regular expression | ||
regex="^(feat|fix|docs|style|refactor|perf|test|chore|revert|release)(\(($scopes|required)\))?: .+$" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
our default commits post release is chore (release)
we should update regex to enable that as well.
Also, we have in our runbook Its for branch nvmhot-fix/
which does not really conform to this. Maybe we should update the runbook or allow for it for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the merging release back to main PR has hardedcoded name as chore: Merge release into main
:
gh pr create -B main -H $TEMP_BRANCH_NAME --title 'chore: Merge release into main' --body 'Merge the recently completed release back into the main development branch. Generated by the callable-npm-publish-release workflow.' |
Have you looked into the commitlint cli which can be used to validate if a string is in conventional commit format? The conventional commit can be configured with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this !
eaeb9f0
Description of changes
Check PR title following the conventional commit format: https://www.conventionalcommits.org
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.