chore: add PR title check workflow #13872
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuiSF
force-pushed
the
hui/chore/conventional-commit-gha
branch
3 times, most recently
from
8efc2a5
to
9bcfaa5
Compare
HuiSF
force-pushed
the
hui/chore/conventional-commit-gha
branch
from
9bcfaa5
to
f014b03
Compare
ashika112
reviewed
Oct 1, 2024
| scopes=$(ls -d ./packages/*/ 2>/dev/null | xargs -n 1 basename | tr '\n' '|' | sed 's/|$//') | ||
|
|
||
| # Generate the regular expression | ||
| regex="^(feat|fix|docs|style|refactor|perf|test|chore|revert|release)(\(($scopes|required)\))?: .+$" |
There was a problem hiding this comment.
our default commits post release is chore (release) we should update regex to enable that as well.
Also, we have in our runbook Its for branch nvmhot-fix/ which does not really conform to this. Maybe we should update the runbook or allow for it for now.
There was a problem hiding this comment.
I think the merging release back to main PR has hardedcoded name as chore: Merge release into main:
|
Have you looked into the commitlint cli which can be used to validate if a string is in conventional commit format? The conventional commit can be configured with |
AllanZhengYP
previously approved these changes
Oct 2, 2024
ashwinkumar6
previously approved these changes
Oct 2, 2024
jjarvisp
previously approved these changes
Oct 3, 2024
ashika112
previously approved these changes
Oct 3, 2024
HuiSF
dismissed stale reviews from ashika112, jjarvisp, ashwinkumar6, and AllanZhengYP
via
eaeb9f0
cshfang
approved these changes
Oct 8, 2024
ashika112
approved these changes
Oct 8, 2024
AllanZhengYP
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Check PR title following the conventional commit format: https://www.conventionalcommits.org
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.