Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): add support for Email MFA #13945

Merged
merged 16 commits into from
Oct 31, 2024
Merged

feat(auth): add support for Email MFA #13945

merged 16 commits into from
Oct 31, 2024

Conversation

jjarvisp
Copy link
Member

@jjarvisp jjarvisp commented Oct 22, 2024

Description of changes

The purpose of this pull request is to enable support for multi-factor authentication with email.

Issue #, if available

Description of how you validated changes

  • manual tests
  • unit tests
  • integration tests

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jjarvisp and others added 9 commits September 6, 2024 15:38
* add EMAIL MFA option in fetchMFAPreference

* add EMAIL MFA option in updateMFAPreference

* update fetchMFAPreference tests

* update updateMFAPreference tests

* update bundle size

* remove redundant assertions
* Confirm Sign In With Email OTP

* Confirm Sign In Tests With Email OTP

* Update packages/auth/src/types/models.ts

Co-authored-by: israx <70438514+israx@users.noreply.github.com>

* Fix Errant Pascal Casing

---------

Co-authored-by: israx <70438514+israx@users.noreply.github.com>
)

* Sign In / Confirm Sign In With MFA_SETUP

* Sign In State Management Tests

* Confirm Sign In Happy Path Tests

* Fix State Management Tests

* Apply Feedback

* loose email matching

* Remove Unnecessary Export

* Update SignInHelpers For Getting Allowed MFA Setup Types

* Add Error Case Unit Tests
… swapping (#13794)

* chore: enable mfa integ tests

* chore: add mfa-setup test def
ashika112
ashika112 previously approved these changes Oct 24, 2024
ashika112
ashika112 previously approved these changes Oct 25, 2024
HuiSF
HuiSF previously approved these changes Oct 29, 2024
@jjarvisp jjarvisp dismissed stale reviews from ashika112 and HuiSF via d2d4470 October 31, 2024 01:07
cshfang
cshfang previously approved these changes Oct 31, 2024
ashika112
ashika112 previously approved these changes Oct 31, 2024
@jjarvisp jjarvisp dismissed stale reviews from ashika112 and cshfang via 8f46f05 October 31, 2024 17:34
@jjarvisp jjarvisp merged commit 42db720 into main Oct 31, 2024
30 checks passed
@jjarvisp jjarvisp deleted the feat/email-mfa branch October 31, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants