Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(auth): provide NEXT_PUBLIC_BACKEND_CONFIG for resumable mfa E2E #14090

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix(auth): provide NEXT_PUBLIC_BACKEND_CONFIG for resumable mfa E2E #14090

merged 1 commit into from
Dec 19, 2024

Conversation

joon-won
Copy link
Member

Description of changes

  • Provide NEXT_PUBLIC_BACKEND_CONFIG as env variable for sign-in-resumable-mfa

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@joon-won joon-won requested a review from a team as a code owner December 19, 2024 00:12
@joon-won joon-won merged commit 29b6c3f into main Dec 19, 2024
31 checks passed
@joon-won joon-won deleted the joonwonc/fix-resumsignin-e2e-param branch December 19, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjarvisp jjarvisp jjarvisp approved these changes

@HuiSF HuiSF HuiSF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joon-won @HuiSF @jjarvisp