Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve next.js integration. Call getInitialProps from HOC. #3741

Closed
wants to merge 1 commit into from
Closed

Improve next.js integration. Call getInitialProps from HOC. #3741

wants to merge 1 commit into from

Conversation

stephankaag
Copy link

Pass getInitialProps through to the child component.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jskrt
Copy link

jskrt commented Aug 6, 2019

I need this for something I'm working on currently. Any idea when this will be approved?

@jordanranz jordanranz added the React React related issues label Aug 13, 2019
@ericclemmons ericclemmons added the SSR Issues related to Server Side Rendering label Mar 17, 2020
@ericclemmons ericclemmons added this to the Support SSR milestone Mar 17, 2020
@ericclemmons
Copy link
Contributor

Thanks for the PR! I have some validation to do and some merge conflicts to resolve.

In the meantime, I added it to the SSR milestone for tracking.

@ericclemmons ericclemmons self-assigned this Apr 24, 2020
@amhinson amhinson changed the base branch from master to main June 18, 2020 19:05
@ericclemmons
Copy link
Contributor

Thanks for your PR! I apologize for taking so long to get to it: aws-amplify-react was updated & migrated to @aws-amplify/ui-react.

If this feature is still desired, can you open a new issue so we can address it in this new package?

Related, SSR support for Next.js has been addressed as part of #6146.

Please see my synopsis on changes here: #5435 (comment)

I would also recommend migrating to the new getServerSideProps API for Next.js, which will remove the need for passing getInitialProps through higher-order components.

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
React React related issues SSR Issues related to Server Side Rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants