Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes(#3620) #3793

Closed
wants to merge 8 commits into from
Closed

fixes(#3620) #3793

wants to merge 8 commits into from

Conversation

haverchuck
Copy link
Contributor

@haverchuck haverchuck commented Aug 1, 2019

Issue #, if available:
fixes(#3620)

Description of changes:
This will allow users to use the strict template check option for Angular AOT compilation.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@haverchuck haverchuck marked this pull request as ready for review August 2, 2019 14:55
@haverchuck haverchuck changed the title makeServicePublic fixes(#3620) Aug 2, 2019
@haverchuck haverchuck requested a review from mlabieniec August 2, 2019 14:56
@tjleing tjleing self-assigned this Aug 9, 2019
@tjleing
Copy link
Contributor

tjleing commented Sep 6, 2019

The changes definitely look good. Just recording my testing experience here before I go...

It took me a while, but I got the changes to be included correctly and it looks like it does in fact fix the issue with protected variables not being accessible. However, I was still unable to get the angular project to compile with AOT for two reasons:

  1. rxjs. error TS2307: Cannot find module 'rxjs/Subject', in import { Subject } from 'rxjs/Subject'; -- it looks like in rxjs version 6, it's just import { Subject } from 'rxjs';. I tried pinning rxjs to a lower version, but Angular requires at least rxjs 5.6.0-forward-compat.0, which still gives the Cannot find module 'rxjs/Subject' errors (plus some more, to boot).

  2. @ViewChild. The error here was An argument for 'opts' was not provided -- in Angular 8, @ViewChild requires two parameters instead of one, also passing an object like {static: false}. I feel like the previous problem might just be because of a versioning error or something, but this one I'm pretty sure will need to be fixed before Angular 8 AOT support at least.

Copy link
Contributor

@tjleing tjleing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it fixes the problem under discussion, I'll go ahead and approve it. But be sure to read the comment! :)

@antoinebrault
Copy link

any ETA for the merge ?

Copy link
Contributor

@ericclemmons ericclemmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts need to be resolved & we should validate that this resolves #4681 as well.

@dsoegijono
Copy link

@haverchuck Any chance of updating this?

@amhinson amhinson changed the base branch from master to main June 18, 2020 19:05
@sammartinez
Copy link
Contributor

Closing pull request as issue was addressed

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants