-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes(#3620) #3793
fixes(#3620) #3793
Conversation
The changes definitely look good. Just recording my testing experience here before I go... It took me a while, but I got the changes to be included correctly and it looks like it does in fact fix the issue with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it fixes the problem under discussion, I'll go ahead and approve it. But be sure to read the comment! :)
any ETA for the merge ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conflicts need to be resolved & we should validate that this resolves #4681 as well.
@haverchuck Any chance of updating this? |
Closing pull request as issue was addressed |
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
fixes(#3620)
Description of changes:
This will allow users to use the strict template check option for Angular AOT compilation.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.