fix(aws-amplify-react): BREAKING - Remove "import '@aws-amplify/ui/dist/style.css'" #5138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericclemmons
added
React
ericclemmons
added a commit
to aws-amplify/docs
that referenced
this pull request
Mar 18, 2020
BREAKING - This coincides with aws-amplify/amplify-js#5138
Codecov Report
@@ Coverage Diff @@
## modularization #5138 +/- ##
==================================================
- Coverage 75.85% 75.84% -0.01%
==================================================
Files 177 177
Lines 9682 9681 -1
Branches 1909 1909
==================================================
- Hits 7344 7343 -1
Misses 2187 2187
Partials 151 151
Continue to review full report at Codecov.
|
Importing non-JS files relies on a bundler & breaks SSR. It works with CRA because CRA *builds all dependencies*, just-in-case.
ericclemmons
requested review from
Ashish-Nanda,
elorzafe,
iartemiev,
jordanranz,
manueliglesias and
sammartinez
as code owners
|
@ericclemmons @sammartinez Thanks for addressing this – it's been a major pain point for us on a Next.js app we're building. What would be the best way for us to start using the package with this change, while it's still pending a release candidate? This package being in a monorepo complicates this a bit. |
|
@sawyerh We're doing a major release in 1 or 2 business days which will contain this fix, as it's a breaking change. (I'm investigating solutions for PR releases, but unfortunately that's not available yet.) |
|
@ericclemmons That's really great to hear, thank you! |
|
@ericclemmons Sorry to pester you – any update on timeline for this being released in some fashion? |
|
@sawyerh We are looking to do a release in the coming weeks. Verifying final issues and will provide an update mid next week if something changes |
jordanranz
added a commit
that referenced
this pull request
Mar 27, 2020
* Adding database abstraction for AsyncStorage * Add storage adapter for React Native using AsyncStorage * Add separate default adapters for Web and React Native * Make error messages more meaningful * Add support for Reachability in React Native * Add @react-native-community/netinfo to devDependencies * Pin down the version of crypto-js * Enable publish from rn-datastore branch * Preparing release * chore(release): Publish [ci skip] - @aws-amplify/analytics@2.2.5 - aws-amplify-angular@4.1.6 - aws-amplify-react@3.1.6 - aws-amplify@2.2.5 - @aws-amplify/datastore@1.0.7 - @aws-amplify/pubsub@2.1.6 * Allow in PubSub to add async custom headers Allow in PubSub the same capabilities as API for custom headers: * Async header * Override headers (Authorization) Check issue #4928 for explanations. * chore(deps-dev): bump codecov from 1.0.1 to 3.6.5 (#4951) Bumps [codecov](https://github.com/codecov/codecov-node) from 1.0.1 to 3.6.5. - [Release notes](https://github.com/codecov/codecov-node/releases) - [Commits](https://github.com/codecov/codecov-node/commits) Signed-off-by: dependabot[bot] <support@github.com> * (fix:@aws-amplify/pubsub) Fix for unsubscription new subscription race condition (#4956) * Fix for unsubscription new subscription race condition * Update packages/pubsub/src/Providers/AWSAppSyncRealTimeProvider.ts * Fix to initialize only once and handle disconnection from network (#4921) * initialize only once * Fix onerror handler for WebSocket * Change log level for unsubscribe message * Add regions and fix typo * Handle disconnection * chore(deps): bump nokogiri from 1.10.4 to 1.10.8 in /docs (#4974) Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.4 to 1.10.8. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.10.4...v1.10.8) Signed-off-by: dependabot[bot] <support@github.com> * Use the db instance property of the Adapter class for all database operations (#4995) Use the db instance property of the Adapter class for all database operations * Removing unused code * Remove rn-datastore branch publish config * Preparing release * chore(release): Publish [ci skip] - amazon-cognito-identity-js@3.2.5 - @aws-amplify/analytics@2.2.6 - @aws-amplify/api@2.1.6 - @aws-amplify/auth@2.1.6 - aws-amplify-angular@4.1.7 - aws-amplify-react@3.1.7 - aws-amplify@2.2.6 - @aws-amplify/cache@2.1.6 - @aws-amplify/core@2.2.5 - @aws-amplify/datastore@1.0.8 - @aws-amplify/interactions@2.1.6 - @aws-amplify/predictions@2.1.6 - @aws-amplify/pubsub@2.1.7 - @aws-amplify/pushnotification@2.1.6 - @aws-amplify/storage@2.2.1 - @aws-amplify/xr@1.1.6 * fix(core): move react-native dependency from dev * fix(core): revert dep addition. Add to peer and devDeps * ci: Add React Native integration testing with Detox (#5007) * Make deploy wait on integ_rn_ios_storage (#5009) * feat(@aws-amplify/api): pass additionalHeaders to graphql function (#5001) Additional headers are merged **after** merging in headers set at config time. Additional headers will overwrite any existing values and merge the rest. * chore(@aws-amplify/api): fix non-breaking typo in function (#5034) * fix(@aws-amplify/datastore): Fix query and delete types (#5032) Fixes #4827 * Fix(@aws-amplify/interactions) fixes 4750 to properly use the spread operator (#4806) * fix(@aws-amplify/datastore) Adding socket disconnection detection (#5086) * Export necessary providers and types from the package root to avoid importing from generated paths (#5085) * fix(aws-amplify-react): Fix Federated icons when using React Bo… (#5073) * Explicitly set box-sizing, as CSS resets override to border-box * Explicitly set line-height, as CSS resets override line-height * Upgrade aws-sdk clients which resolves react native issues (#5124) * Export necessary providers and types from the package root to avoid importing from generated paths * Upgrade aws-sdk clients which resolves react native issues * Enable integration tests on modularization branch (#5125) * chore: Fix setup-dev script (#5035) Let `unlink-all` succeed always Co-authored-by: Iglesias <manuelig@3c22fb19fec4.ant.amazon.com> * fix(@aws-amplify/datastore): Storage should be re-initialized after DataStore.clear() (#5083) * fix(@aws-amplify/datastore): Fix #5076 storage not re-initialized after DataStore.clear() * Adding comments Co-authored-by: Manuel Iglesias <manuelig@amazon.com> Co-authored-by: Ashish Nanda <ashish.nanda.5591@gmail.com> * fix(aws-amplify-react): BREAKING - Remove "import '@aws-amplify… (#5138) Importing non-JS files relies on a bundler & breaks SSR. It works with CRA because CRA *builds all dependencies*, just-in-case. * feat(@aws-amplify/datastore): Support non-@model types in DataStore (#5128) * Upgrade immer * Return sooner if predicates are empty * Fix bug when trying to delete a model instance that is not persisted * Support non-@model types * Generate datastore coverage report and RN integ test * Fix tslint error * Remove unit test case for onGetPost * Remove unused code * Rename instance initializer to initializeInstance * Rename SchemaType to SchemaNonModel * Rename types to nonModels in schema.js * Rename type to nonModel * Make nonModels optional in schema.js * Remove generic constraint from createTypeClass * Rename ModelOrTypeConstructorMap to TypeConstructorMap * Rename createModelAndTypeClassses to createTypeClasses * Rename createTypeClass to createNonModelClass * chore: remove datastore form RN integ tests (#5139) * Fix export type of datastore storage in unit tests * test(@aws-amplify/datastore): Fix unit tests * [RN] Migrate zen-observable to zen-observable-ts and fix zen-push import (#5155) * Migrate zen-observable to zen-observable-ts and fix zen-push import * Fix unit tests * Pin aws-sdk versions and rename presignRequest to presign (#5171) * Migrate zen-observable to zen-observable-ts and fix zen-push import * Fix unit tests * Pin aws-sdk versions and rename presignRequest to presign * Upgrade aws-sdk clients from alpha to beta (#5209) * Migrate zen-observable to zen-observable-ts and fix zen-push import * Fix unit tests * Pin aws-sdk versions and rename presignRequest to presign * Upgrade aws-sdk clients from alpha to beta * Update expiration type to Date as per change in aws-sdk * Fix unit tests as per expiration type change * Fix jest failures, update snapshot * Update storage changelog Co-authored-by: Ashish Nanda <ashish.nanda.5591@gmail.com> Co-authored-by: Rodriguez Elorza <elorzafe@amazon.com> Co-authored-by: aws-amplify-bot <aws@amazon.com> Co-authored-by: Sebastien Schwartz <schwartz.seb@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Manuel Iglesias <manuelig@amazon.com> Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com> Co-authored-by: Jens Bodal <jensbodal@gmail.com> Co-authored-by: Ashika <35131273+ashika01@users.noreply.github.com> Co-authored-by: Manuel Iglesias <6154160+manueliglesias@users.noreply.github.com> Co-authored-by: Praveen Gupta <51211245+Amplifiyer@users.noreply.github.com> Co-authored-by: Eric Clemmons <eric@smarterspam.com> Co-authored-by: Iglesias <manuelig@3c22fb19fec4.ant.amazon.com> Co-authored-by: Yirako <yirako@users.noreply.github.com> Co-authored-by: pravgupt@amazon.com <pravgupt@8c85905cd208.ant.amazon.com>
7 tasks
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will require a MAJOR version bump, ideally with
modularization.Issue #, if available: Fixes #3348, fixes #3854, fixes #2230, fixes #3053. Related to #1613, but there's more work to be done to support categories in Next.js.
Importing non-JS files is invalid JavaScript, as it relies on a bundler (e.g. webpack) & breaks SSR for Next.js.
It works with CRA because CRA builds all dependencies, just-in-case.
Docs PR: aws-amplify/docs#1258
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.