-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Callback with error if error thrown due to network #605
Merged
mlabieniec
merged 9 commits into
aws-amplify:master
from
cheedep:bug/cognito-js-network-errors
Apr 19, 2018
+33
−10
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
171b218
Callback with error if error thrown due to network
cheedep 126664e
remove unnecessary brackets
cheedep ee4addd
fix spacing
cheedep f2ab706
handle fetch request failure and throw error /w message 'Network error'
cheedep 724967c
return Unknown error for anything other than Network error. Some linting
cheedep f5cb093
comments
cheedep 0711c48
Merge branch 'master' into bug/cognito-js-network-errors
mlabieniec 5579e94
Merge branch 'master' into bug/cognito-js-network-errors
mlabieniec 26e0f08
Merge branch 'master' into bug/cognito-js-network-errors
mlabieniec File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should probably return:
return throw new Error('Network error');
or run an
} else {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Throwing an error automatically returns control to the caller. You dont need return or a branch here.