Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

able to set proxy agent to cognito http client #724

Closed

Conversation

richardzcode
Copy link
Contributor

Be able to set "agent" property to cognito http client.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@richardzcode richardzcode requested a review from yuntuowang April 24, 2018 21:00
@codecov-io
Copy link

codecov-io commented Apr 24, 2018

Codecov Report

Merging #724 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #724   +/-   ##
======================================
  Coverage    86.6%   86.6%           
======================================
  Files          74      74           
  Lines        3538    3538           
  Branches      674     674           
======================================
  Hits         3064    3064           
  Misses        456     456           
  Partials       18      18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e8e9db...70b39a0. Read the comment docs.

Copy link
Contributor

@yuntuowang yuntuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me.

Copy link
Contributor

@powerful23 powerful23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 By the way, should we put this change in the doc?

@nidsharm nidsharm added review Cognito Related to cognito issues labels Oct 22, 2018
Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@powerful23 what do you think?

body: JSON.stringify(params),
};
const options = Object.assign(
this.options,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be the opposite way, this.options should be at the end

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

@powerful23
Copy link
Contributor

@richardzcode can you make the change mentioned above and resolve the conflicts so we can merge this into the repo? Thanks.

@elorzafe
Copy link
Contributor

@powerful23 what should we do with this pr?

@powerful23
Copy link
Contributor

@richardzcode I am going to close this pr now. If you want to continue merging this, please reopen it.

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Cognito Related to cognito issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants