-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
able to set proxy agent to cognito http client #724
Conversation
Codecov Report
@@ Coverage Diff @@
## master #724 +/- ##
======================================
Coverage 86.6% 86.6%
======================================
Files 74 74
Lines 3538 3538
Branches 674 674
======================================
Hits 3064 3064
Misses 456 456
Partials 18 18 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 By the way, should we put this change in the doc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@powerful23 what do you think?
body: JSON.stringify(params), | ||
}; | ||
const options = Object.assign( | ||
this.options, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be the opposite way, this.options
should be at the end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree
@richardzcode can you make the change mentioned above and resolve the conflicts so we can merge this into the repo? Thanks. |
@powerful23 what should we do with this pr? |
@richardzcode I am going to close this pr now. If you want to continue merging this, please reopen it. |
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Be able to set "agent" property to cognito http client.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.