feat(@aws-amplify/ui-vue): Use @aws-amplify/ui-components for Vue 3
#7634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlee221
changed the title
@aws-amplify/ui-components for Vue 3
Codecov Report
@@ Coverage Diff @@
## main #7634 +/- ##
=======================================
Coverage 74.10% 74.10%
=======================================
Files 214 214
Lines 13405 13405
Branches 2626 2626
=======================================
Hits 9934 9934
Misses 3272 3272
Partials 199 199 Continue to review full report at Codecov.
|
dgonsan
pushed a commit
to dgonsan/amplify-js
that referenced
this pull request
Mar 18, 2021
…aws-amplify#7634) * Add Vue 3 Integration tests * Add warning message for Vue 2 * Try adding peer dependency * throw error instead * Fix whitespace Co-authored-by: Sam Martinez <samlmar@amazon.com>
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #6756, #7456
Description of changes: We will now use
@aws-amplify/ui-componentsto support Vue 3 and onwards. Vue 2 users can keep using@aws-amplify/ui-vue. This PR creates warning mechanisms whenever user tries to useui-vuewith Vue 3.Background
Vue 3 brings major API changes such that it's hard to configure both Vue 2 and Vue 3 inside the same package:
Vueis now deprecated.ignoredElementis renamed toisCustomElementand can no longer be configured from library side.ui-vuepackage will be harder to maintain as we to adapt to future versions of Vue.For these reasons, we'll instruct the customers to use
@aws-amplify/ui-componentsinstead. Documentation updates are tracked in aws-amplify/docs#2880PR Changes
This PR creates warning mechanisms for using
ui-vueon Vue 3 app:import '@aws-amplify/ui-vue'"Vue": "2.x.x"to@aws-amplify/ui-vueIn addition, we run integration tests for vue 3 samples we are adding in https://github.com/aws-amplify/amplify-js-samples-staging/pull/192.
Screenshots
On yarn and npm 6
Installing
ui-vueon Vue 3 gives a warning:If customer serves that app, this will show an error on console:
On npm 7
Installing
ui-vueon Vue 3 fails (which is really nice!).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.