Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@aws-amplify/ui-components): handle non-username alias cases #7663

Merged
merged 2 commits into from
Feb 1, 2021

Conversation

wlee221
Copy link
Contributor

@wlee221 wlee221 commented Feb 1, 2021

Issue #, if available: fixes #7636

Description of changes: Checks for empty string and undefined before doing any string operation.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #7663 (cc36343) into main (1602377) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7663   +/-   ##
=======================================
  Coverage   74.10%   74.10%           
=======================================
  Files         214      214           
  Lines       13405    13405           
  Branches     2626     2626           
=======================================
  Hits         9934     9934           
  Misses       3272     3272           
  Partials      199      199           
Impacted Files Coverage Δ
packages/core/src/Platform/version.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88cba94...cc36343. Read the comment docs.

Copy link
Contributor

@sammartinez sammartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants