Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(new-issue-form): add version ref section + collapsible sections #7927

Merged
merged 6 commits into from
Mar 17, 2021

Conversation

siegerts
Copy link
Contributor

Description of changes:

  • added version reference section
  • added collapsible <details></details> md in placeholder values for larger input fields

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@siegerts siegerts requested a review from sammartinez as a code owner March 12, 2021 17:45
@siegerts siegerts requested a review from amhinson March 12, 2021 17:47
@siegerts
Copy link
Contributor Author

@sammartinez, the to-be-reproduced default label hasn't been added. Is this still correct?

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #7927 (0628e90) into main (075ec88) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7927   +/-   ##
=======================================
  Coverage   74.25%   74.25%           
=======================================
  Files         215      215           
  Lines       13473    13473           
  Branches     2646     2646           
=======================================
  Hits        10004    10004           
  Misses       3271     3271           
  Partials      198      198           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 075ec88...0628e90. Read the comment docs.

@siegerts siegerts changed the title chore: add version ref section + collapsible sections chore(new-issue-form): add version ref section + collapsible sections Mar 12, 2021
Copy link
Contributor

@sammartinez sammartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants