Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@aws-amplify/datastore): keep syncing when subs disabled #7987

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

iartemiev
Copy link
Member

@iartemiev iartemiev commented Mar 24, 2021

e2e test: https://github.com/aws-amplify/amplify-js-samples-staging/pull/207

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@iartemiev iartemiev added the DataStore Related to DataStore category label Mar 24, 2021
@iartemiev iartemiev requested a review from amhinson March 24, 2021 18:19
@iartemiev
Copy link
Member Author

@richardmcclellan - could you please take a look as well? The e2e test is in a separate private repo, I'll add you to it

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #7987 (3d9eecf) into main (dd98afb) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7987      +/-   ##
==========================================
- Coverage   74.25%   74.24%   -0.01%     
==========================================
  Files         215      215              
  Lines       13473    13474       +1     
  Branches     2646     2647       +1     
==========================================
  Hits        10004    10004              
- Misses       3271     3272       +1     
  Partials      198      198              
Impacted Files Coverage Δ
...ages/datastore/src/sync/processors/subscription.ts 37.57% <0.00%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd98afb...3d9eecf. Read the comment docs.

Copy link
Contributor

@amhinson amhinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

My own nitpick would be to combine this with the message.includes() block above, but I'll leave that up to you.

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DataStore Related to DataStore category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants