chroe(geo): better error handling when missing location service resources #8899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaddmt
approved these changes
Sep 14, 2021
Comment on lines
+259
to
+263
| logger.debug('Set credentials for storage. Credentials are:', cred); | ||
| this._config.credentials = cred; | ||
| return true; | ||
| } catch (error) { | ||
| logger.warn('ensure credentials error', error); | ||
| logger.warn('Ensure credentials error. Credentials are:', error); |
There was a problem hiding this comment.
Should we be logging the credentials at all here?
There was a problem hiding this comment.
This is what we do with this function in other categories. It will help to debug when an error is happening due to different circumstances (undefined, malformed, etc)
Codecov Report
@@ Coverage Diff @@
## geo/staging #8899 +/- ##
===============================================
+ Coverage 78.00% 78.04% +0.04%
===============================================
Files 246 246
Lines 17660 17674 +14
Branches 3793 3797 +4
===============================================
+ Hits 13776 13794 +18
+ Misses 3755 3752 -3
+ Partials 129 128 -1
Continue to review full report at Codecov.
|
TreTuna
added a commit
that referenced
this pull request
Sep 14, 2021
* choree(geo): better error handling when missing location service resources (#8899) * chore(geo): update config type * chore(geo): better error handling when missing resources * chore(geo): add test for no search index by coordinates * chore(geo): update error messaging to remind to `amplify push`
TreTuna
added a commit
that referenced
this pull request
Sep 23, 2021
* choree(geo): better error handling when missing location service resources (#8899) * chore(geo): update config type * chore(geo): better error handling when missing resources * chore(geo): add test for no search index by coordinates * chore(geo): update error messaging to remind to `amplify push`
TreTuna
added a commit
that referenced
this pull request
Sep 23, 2021
* choree(geo): better error handling when missing location service resources (#8899) * chore(geo): update config type * chore(geo): better error handling when missing resources * chore(geo): add test for no search index by coordinates * chore(geo): update error messaging to remind to `amplify push`
TreTuna
added a commit
that referenced
this pull request
Sep 23, 2021
* choree(geo): better error handling when missing location service resources (#8899) * chore(geo): update config type * chore(geo): better error handling when missing resources * chore(geo): add test for no search index by coordinates * chore(geo): update error messaging to remind to `amplify push`
iartemiev
pushed a commit
that referenced
this pull request
Sep 23, 2021
* choree(geo): better error handling when missing location service resources (#8899) * chore(geo): update config type * chore(geo): better error handling when missing resources * chore(geo): add test for no search index by coordinates * chore(geo): update error messaging to remind to `amplify push`
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds better error handling to tell developers what's happening and what to do to solve the issue
Description of how you validated changes
Unit tests
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.