-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: upgrade ts to 3.8 to use export type syntax #9122
Changes from 7 commits
3906dec
80d3ec7
da61bdd
16e0512
7078fdf
a3d66e7
06632b1
b5acb76
8596633
b87e585
5cc9a92
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,24 @@ | ||
/* | ||
* Copyright 2017-2019 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"). You may not use this file except in compliance with | ||
* the License. A copy of the License is located at | ||
* | ||
* http://aws.amazon.com/apache2.0/ | ||
* | ||
* or in the "license" file accompanying this file. This file is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR | ||
* CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions | ||
* and limitations under the License. | ||
*/ | ||
/** | ||
* This exports from the types directory is a temporary workaround, since Amplify CLI currently | ||
* generates code that relies on this import path https://github.com/aws-amplify/amplify-cli/issues/3863 | ||
* This will be removed in future release when CLI and customers moves to recommeneded import styles. | ||
*/ | ||
export { | ||
graphqlOperation, | ||
GraphQLAuthError, | ||
GraphQLResult, | ||
GRAPHQL_AUTH_MODE, | ||
} from '@aws-amplify/api-graphql'; | ||
/* | ||
* Copyright 2017-2019 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
hkjpotato marked this conversation as resolved.
Show resolved
Hide resolved
|
||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"). You may not use this file except in compliance with | ||
* the License. A copy of the License is located at | ||
* | ||
* http://aws.amazon.com/apache2.0/ | ||
* | ||
* or in the "license" file accompanying this file. This file is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR | ||
* CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions | ||
* and limitations under the License. | ||
*/ | ||
|
||
/** | ||
* This exports from the types directory is a temporary workaround, since Amplify CLI currently | ||
* generates code that relies on this import path https://github.com/aws-amplify/amplify-cli/issues/3863 | ||
* This will be removed in future release when CLI and customers moves to recommeneded import styles. | ||
*/ | ||
export { | ||
graphqlOperation, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am not sure why this file shows up on the diff, nothing should be changed There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That is strange but can we update the copyright date :) |
||
GraphQLAuthError, | ||
GraphQLResult, | ||
GRAPHQL_AUTH_MODE, | ||
} from '@aws-amplify/api-graphql'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update
pretty-quick
along withprettier
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested its newer version but from the current version's peerDependencies, it works with prettier >=1.8.0, so I think it might be safer to keep it now.