Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: keep @babel/traverse on prior version to unblock build #9859

Merged
merged 1 commit into from
May 2, 2022

Conversation

svidgen
Copy link
Member

@svidgen svidgen commented May 2, 2022

Description of changes

A fresh clone from main is failing to build.

amazon-cognito-identity-js: TypeError: /workspace/amplify-js/packages/amazon-cognito-identity-js/src/AuthenticationDetails.js: isTopicReference is not a function
amazon-cognito-identity-js:     at Scope.isStatic (/workspace/amplify-js/node_modules/@babel/traverse/lib/scope/index.js:439:52)
amazon-cognito-identity-js:     at Scope.maybeGenerateMemoised (/workspace/amplify-js/node_modules/@babel/traverse/lib/scope/index.js:457:14)
amazon-cognito-identity-js:     at DestructuringTransformer.init (/workspace/amplify-js/node_modules/@babel/plugin-transform-destructuring/lib/index.js:298:31)
amazon-cognito-identity-js:     at convertVariableDeclaration (/workspace/amplify-js/node_modules/@babel/plugin-transform-destructuring/lib/index.js:385:21)
amazon-cognito-identity-js:     at PluginPass.VariableDeclaration (/workspace/amplify-js/node_modules/@babel/plugin-transform-destructuring/lib/index.js:591:9)
amazon-cognito-identity-js:     at newFn (/workspace/amplify-js/node_modules/@babel/traverse/lib/visitors.js:177:21)
amazon-cognito-identity-js:     at NodePath._call (/workspace/amplify-js/node_modules/@babel/traverse/lib/path/context.js:53:20)
amazon-cognito-identity-js:     at NodePath.call (/workspace/amplify-js/node_modules/@babel/traverse/lib/path/context.js:40:17)
amazon-cognito-identity-js:     at NodePath.visit (/workspace/amplify-js/node_modules/@babel/traverse/lib/path/context.js:100:31)
amazon-cognito-identity-js:     at TraversalContext.visitQueue (/workspace/amplify-js/node_modules/@babel/traverse/lib/context.js:103:16) {
amazon-cognito-identity-js:   code: 'BABEL_TRANSFORM_ERROR'
amazon-cognito-identity-js: }

This is related to changes in @babel/traverse at 7.17.10. The quick fix is to pin this package to 7.17.9.

Issue #, if available

#9858

Description of how you validated changes

Repro'd the issue:

rm -rf node_modules
rm -rf packages/*/node_modules
yarn setup-dev

Pinned the package, re-ran repro steps, and had a working build.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@iartemiev iartemiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@codecov-commenter
Copy link

Codecov Report

Merging #9859 (a2b4a5c) into main (949d17b) will increase coverage by 1.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #9859      +/-   ##
==========================================
+ Coverage   82.10%   83.16%   +1.06%     
==========================================
  Files         257      257              
  Lines       19065    18511     -554     
  Branches     4117     3994     -123     
==========================================
- Hits        15653    15395     -258     
+ Misses       3283     3020     -263     
+ Partials      129       96      -33     
Impacted Files Coverage Δ
...vue/src/components/authenticator/ConfirmSignIn.vue 100.00% <0.00%> (+6.25%) ⬆️
...aws-amplify-vue/src/components/storage/S3Image.vue 100.00% <0.00%> (+7.14%) ⬆️
...vue/src/components/authenticator/ConfirmSignUp.vue 100.00% <0.00%> (+9.52%) ⬆️
...fy-vue/src/components/authenticator/PhoneField.vue 100.00% <0.00%> (+11.11%) ⬆️
...vue/src/components/authenticator/Authenticator.vue 100.00% <0.00%> (+12.50%) ⬆️
...plify-vue/src/components/authenticator/SignOut.vue 100.00% <0.00%> (+21.42%) ⬆️
...mplify-vue/src/components/authenticator/SignUp.vue 100.00% <0.00%> (+35.29%) ⬆️
...aws-amplify-vue/src/components/storage/S3Album.vue 100.00% <0.00%> (+36.36%) ⬆️
...mplify-vue/src/components/authenticator/SetMFA.vue 100.00% <0.00%> (+37.83%) ⬆️
...ue/src/components/authenticator/ForgotPassword.vue 100.00% <0.00%> (+38.70%) ⬆️
... and 7 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@svidgen svidgen merged commit 98b6e11 into aws-amplify:main May 2, 2022
jamesaucode pushed a commit to jamesaucode/amplify-js that referenced this pull request May 4, 2022
@github-actions
Copy link

github-actions bot commented May 3, 2023

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server amplify-help forum.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants