Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(logging): fix integration test failures #3297

Merged
merged 8 commits into from
Oct 17, 2023
Merged

Conversation

phantumcode
Copy link
Member

@phantumcode phantumcode commented Oct 16, 2023

Issue #

Description

  • Rework logging integration test to run consistently across iOS, tvOS, and watchOS

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phantumcode phantumcode requested a review from a team as a code owner October 16, 2023 17:19
@phantumcode phantumcode temporarily deployed to Fortify October 17, 2023 15:12 — with GitHub Actions Inactive
@phantumcode phantumcode temporarily deployed to IntegrationTest October 17, 2023 15:45 — with GitHub Actions Inactive
@phantumcode phantumcode temporarily deployed to IntegrationTest October 17, 2023 15:45 — with GitHub Actions Inactive
@phantumcode phantumcode temporarily deployed to IntegrationTest October 17, 2023 15:45 — with GitHub Actions Inactive
@phantumcode phantumcode changed the title Logging/fix integration test(logging): fix integration test failures Oct 17, 2023
Copy link
Member

@atierian atierian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

If I'm understanding the change correctly, test runs on different platforms running in parallel shouldn't conflict with each other anymore, e.g:

// run on `main`
// the individual jobs won't conflict with each other
integ_test_logging
   - logging-integration-test-iOS
   - logging-integration-test-tvOS
   - logging-integration-test-watchOS

However, multiple concurrent runs of integ_test_logging can still lead to issues, e.g.:

// run on `main`
integ_test_logging
   - logging-integration-test-iOS
   - logging-integration-test-tvOS
   - logging-integration-test-watchOS

// at the same time, run on `my-cool-feature-branch`
integ_test_logging
   - logging-integration-test-iOS
   - logging-integration-test-tvOS
   - logging-integration-test-watchOS

In this example, for any given platform - logging-integration-test-<platform> run on my-cool-feature-branch can conflict with logging-integration-test-<platform> run on main.

Is that correct?

If so, let's aim to address that in a future PR.

@phantumcode phantumcode merged commit cef43c3 into main Oct 17, 2023
79 checks passed
@phantumcode phantumcode deleted the logging/fix_integration branch October 17, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants