-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(logging): fix integration test failures #3297
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
If I'm understanding the change correctly, test runs on different platforms running in parallel shouldn't conflict with each other anymore, e.g:
// run on `main`
// the individual jobs won't conflict with each other
integ_test_logging
- logging-integration-test-iOS
- logging-integration-test-tvOS
- logging-integration-test-watchOS
However, multiple concurrent runs of integ_test_logging
can still lead to issues, e.g.:
// run on `main`
integ_test_logging
- logging-integration-test-iOS
- logging-integration-test-tvOS
- logging-integration-test-watchOS
// at the same time, run on `my-cool-feature-branch`
integ_test_logging
- logging-integration-test-iOS
- logging-integration-test-tvOS
- logging-integration-test-watchOS
In this example, for any given platform - logging-integration-test-<platform>
run on my-cool-feature-branch
can conflict with logging-integration-test-<platform>
run on main
.
Is that correct?
If so, let's aim to address that in a future PR.
Issue #
Description
General Checklist
Given When Then
inline code documentation and are named accordinglytestThing_condition_expectation()
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.