-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(core): resolve swiftformat errors and warnings #3847
Merged
phantumcode
merged 5 commits into
chore/resolve_swiftformat
from
chore/resolve_swiftformat_core
Oct 11, 2024
Merged
chore(core): resolve swiftformat errors and warnings #3847
phantumcode
merged 5 commits into
chore/resolve_swiftformat
from
chore/resolve_swiftformat_core
Oct 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## chore/resolve_swiftformat #3847 +/- ##
=============================================================
- Coverage 68.51% 67.75% -0.76%
=============================================================
Files 1080 1006 -74
Lines 37608 34296 -3312
=============================================================
- Hits 25766 23237 -2529
+ Misses 11842 11059 -783
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thisisabhash
approved these changes
Oct 11, 2024
phantumcode
merged commit Oct 11, 2024
80908f3
into
chore/resolve_swiftformat
69 of 70 checks passed
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description
Resolving SwiftFormat errors and warnings for Amplify Core.
General Checklist
Given When Then
inline code documentation and are named accordinglytestThing_condition_expectation()
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.