Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update logging integration test #3903

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Oct 21, 2024

Issue #

Fixing failing Logging integration tests on watchOS

Description

Integration Tests | Logging

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.33%. Comparing base (f950c6c) to head (a10c4f4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3903      +/-   ##
==========================================
+ Coverage   69.21%   69.33%   +0.11%     
==========================================
  Files        1087     1087              
  Lines       49366    49366              
==========================================
+ Hits        34167    34226      +59     
+ Misses      15199    15140      -59     
Flag Coverage Δ
API_plugin_unit_test 70.35% <ø> (+0.02%) ⬆️
AWSPluginsCore 70.36% <ø> (ø)
Amplify 48.18% <ø> (ø)
Analytics_plugin_unit_test 85.20% <ø> (ø)
Auth_plugin_unit_test 80.00% <ø> (-0.04%) ⬇️
DataStore_plugin_unit_test 84.13% <ø> (+0.69%) ⬆️
Geo_plugin_unit_test 74.86% <ø> (ø)
Logging_plugin_unit_test 63.11% <ø> (ø)
Predictions_plugin_unit_test 35.49% <ø> (ø)
PushNotifications_plugin_unit_test 88.43% <ø> (ø)
Storage_plugin_unit_test 76.88% <ø> (ø)
unit_tests 69.33% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harsh62 harsh62 marked this pull request as ready for review October 21, 2024 18:54
@harsh62 harsh62 requested a review from a team as a code owner October 21, 2024 18:54
@harsh62 harsh62 merged commit 6bbf569 into main Oct 21, 2024
95 checks passed
@harsh62 harsh62 deleted the logging-integration-test-fix branch October 21, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants