-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): upgrade dependency rexml version to 3.3.9 #3909
Conversation
Gemfile
Outdated
@@ -5,5 +5,6 @@ source 'https://rubygems.org' | |||
gem 'xcpretty', '0.3.0' | |||
gem 'fastlane', '2.205.1' | |||
gem 'jazzy', '0.15.1' | |||
gem 'rexml', '3.3.9' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing this will fail the Dependency Check because it pulls a newer json
version that has an incompatible license.
Instead, just run sudo bundle update rexml
in both locations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the explanation!!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3909 +/- ##
==========================================
- Coverage 69.20% 69.19% -0.02%
==========================================
Files 1087 1087
Lines 49366 49366
==========================================
- Hits 34163 34158 -5
- Misses 15203 15208 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Issue #
https://github.com/aws-amplify/amplify-swift/security/dependabot/26
https://github.com/aws-amplify/amplify-swift/security/dependabot/25
Description
upgrade rexml to 3.3.9 to the Gemfile, and ran bundle update
General Checklist
Given When Then
inline code documentation and are named accordinglytestThing_condition_expectation()
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.