Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): upgrade dependency rexml version to 3.3.9 #3909

Merged
merged 6 commits into from
Oct 29, 2024

Conversation

edisooon
Copy link
Member

Issue #

https://github.com/aws-amplify/amplify-swift/security/dependabot/26
https://github.com/aws-amplify/amplify-swift/security/dependabot/25

Description

upgrade rexml to 3.3.9 to the Gemfile, and ran bundle update

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@edisooon edisooon requested a review from a team as a code owner October 28, 2024 21:43
@edisooon edisooon changed the title Edisooon/chore dependabot fix chore(ci): upgrade dependency rexml version to 3.3.9 Oct 28, 2024
Gemfile Outdated
@@ -5,5 +5,6 @@ source 'https://rubygems.org'
gem 'xcpretty', '0.3.0'
gem 'fastlane', '2.205.1'
gem 'jazzy', '0.15.1'
gem 'rexml', '3.3.9'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing this will fail the Dependency Check because it pulls a newer json version that has an incompatible license.

Instead, just run sudo bundle update rexml in both locations.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the explanation!!

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.19%. Comparing base (2a3de4b) to head (caf6e51).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3909      +/-   ##
==========================================
- Coverage   69.20%   69.19%   -0.02%     
==========================================
  Files        1087     1087              
  Lines       49366    49366              
==========================================
- Hits        34163    34158       -5     
- Misses      15203    15208       +5     
Flag Coverage Δ
API_plugin_unit_test 70.33% <ø> (ø)
AWSPluginsCore 70.36% <ø> (ø)
Amplify 48.18% <ø> (ø)
Analytics_plugin_unit_test 85.20% <ø> (ø)
Auth_plugin_unit_test 80.06% <ø> (-0.04%) ⬇️
DataStore_plugin_unit_test 83.30% <ø> (ø)
Geo_plugin_unit_test 74.86% <ø> (ø)
Logging_plugin_unit_test 63.11% <ø> (ø)
Predictions_plugin_unit_test 35.49% <ø> (ø)
PushNotifications_plugin_unit_test 88.43% <ø> (ø)
Storage_plugin_unit_test 76.88% <ø> (ø)
unit_tests 69.19% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruisebas ruisebas merged commit 80f1eeb into main Oct 29, 2024
93 checks passed
@ruisebas ruisebas deleted the edisooon/chore-dependabot-fix branch October 29, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants