fix(build-system-tests): update tsconfig for create-vite@latest #5335
Conversation
|
| echo "cp templates/components/react/vite/template-tsconfig-vite-${BUILD_TOOL_VERSION}.json mega-apps/${MEGA_APP_NAME}/tsconfig.app.json" | ||
| cp templates/components/react/vite/template-tsconfig-vite-${BUILD_TOOL_VERSION}.json mega-apps/${MEGA_APP_NAME}/tsconfig.app.json |
There was a problem hiding this comment.
Based on this commit: https://github.com/vitejs/vite/pull/15913/files#diff-4aee86d836cbe0aac0d45ef61a8ca540455ef2a7ee667abb3dc1fdac0956b6a5, it looks like we want to overwrite the tsconfig.app.json now.
tsconfig.json should only have references to tsconfig.app.json and tsconfig.node.json
| "references": [ | ||
| { | ||
| "path": "./tsconfig.node.json" | ||
| } | ||
| ] |
There was a problem hiding this comment.
Remove the reference to tsconfig.node.json since that is now automatically being referenced in tsconfig.json
| @@ -1,12 +1,9 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "composite": true, | |||
There was a problem hiding this comment.
Add composite based on this commit: https://github.com/vitejs/vite/pull/15913/files#diff-4aee86d836cbe0aac0d45ef61a8ca540455ef2a7ee667abb3dc1fdac0956b6a5
Description of changes
template-tsconfig-vite-latest.jsonbased on this PR: feat(create-vite): use "solution" tsconfig so that vite.config.ts is type checked vitejs/vite#15913:tsconfig.node.json"composite": trueIssue #, if available
Description of how you validated changes
Checklist
yarn testpasses and tests are updated/addeddocs,e2e,examples, or other private packages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.