-
Notifications
You must be signed in to change notification settings - Fork 21
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Subscription failed event should be terminal event (#74)
- Loading branch information
Showing
9 changed files
with
209 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
190 changes: 190 additions & 0 deletions
190
AppSyncRealTimeClientIntegrationTests/AppSyncRealTimeClientFailureTests.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,190 @@ | ||
| // | ||
| // Copyright Amazon.com Inc. or its affiliates. | ||
| // All Rights Reserved. | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // | ||
|
|
||
| import XCTest | ||
| @testable import AppSyncRealTimeClient | ||
|
|
||
| class AppSyncRealTimeClientFailureTests: AppSyncRealTimeClientTestBase { | ||
|
|
||
| /// Test the current AppSync limit of 100 subscriptions per connection | ||
| func testMaxSubscriptionReached() { | ||
| let subscribeSuccess = expectation(description: "subscribe successfully") | ||
| subscribeSuccess.expectedFulfillmentCount = 100 | ||
| let authInterceptor = APIKeyAuthInterceptor(apiKey) | ||
| let connectionProvider = ConnectionProviderFactory.createConnectionProvider( | ||
| for: url, | ||
| authInterceptor: authInterceptor, | ||
| connectionType: .appSyncRealtime | ||
| ) | ||
| var subscriptions = [AppSyncSubscriptionConnection]() | ||
| for _ in 1 ... 100 { | ||
| let subscription = AppSyncSubscriptionConnection(provider: connectionProvider) | ||
| _ = subscription.subscribe( | ||
| requestString: requestString, | ||
| variables: nil | ||
| ) { event, _ in | ||
| switch event { | ||
| case .connection(let subscriptionConnectionEvent): | ||
| switch subscriptionConnectionEvent { | ||
| case .connecting: | ||
| break | ||
| case .connected: | ||
| subscribeSuccess.fulfill() | ||
| case .disconnected: | ||
| break | ||
| } | ||
| case .data(let data): | ||
| print("Got data back \(data)") | ||
| case .failed(let error): | ||
| XCTFail("Got error \(error)") | ||
| } | ||
| } | ||
| subscriptions.append(subscription) | ||
| } | ||
|
|
||
| wait(for: [subscribeSuccess], timeout: TestCommonConstants.networkTimeout) | ||
| XCTAssertEqual(subscriptions.count, 100) | ||
| let limitExceeded = expectation(description: "Received Limit Exceeded error") | ||
| let subscription = AppSyncSubscriptionConnection(provider: connectionProvider) | ||
| _ = subscription.subscribe( | ||
| requestString: requestString, | ||
| variables: nil | ||
| ) { event, _ in | ||
| switch event { | ||
| case .connection(let subscriptionConnectionEvent): | ||
| switch subscriptionConnectionEvent { | ||
| case .connecting: | ||
| break | ||
| case .connected: | ||
| XCTFail("Got connected successfully - Should have been limit exceeded") | ||
| case .disconnected: | ||
| break | ||
| } | ||
| case .data(let data): | ||
| print("Got data back \(data)") | ||
| case .failed(let error): | ||
| guard let connectionError = error as? ConnectionProviderError, | ||
| case .limitExceeded = connectionError else { | ||
| XCTFail("Should Be Limited Exceeded error") | ||
| return | ||
| } | ||
|
|
||
| limitExceeded.fulfill() | ||
| } | ||
| } | ||
| wait(for: [limitExceeded], timeout: TestCommonConstants.networkTimeout) | ||
|
|
||
| for subscription in subscriptions { | ||
| if let item = subscription.subscriptionItem { | ||
| subscription.unsubscribe(item: item) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /// Subscriptions receiving a failed event should only receive it once. | ||
| func testMaxSubscriptionReachedWithRetry() { | ||
| let subscribeSuccess = expectation(description: "subscribe successfully") | ||
| subscribeSuccess.expectedFulfillmentCount = 100 | ||
| let authInterceptor = APIKeyAuthInterceptor(apiKey) | ||
| let connectionProvider = ConnectionProviderFactory.createConnectionProvider( | ||
| for: url, | ||
| authInterceptor: authInterceptor, | ||
| connectionType: .appSyncRealtime | ||
| ) | ||
| var subscriptions = [AppSyncSubscriptionConnection]() | ||
| for _ in 1 ... 100 { | ||
| let subscription = AppSyncSubscriptionConnection(provider: connectionProvider) | ||
| _ = subscription.subscribe( | ||
| requestString: requestString, | ||
| variables: nil | ||
| ) { event, _ in | ||
| switch event { | ||
| case .connection(let subscriptionConnectionEvent): | ||
| switch subscriptionConnectionEvent { | ||
| case .connecting: | ||
| break | ||
| case .connected: | ||
| subscribeSuccess.fulfill() | ||
| case .disconnected: | ||
| break | ||
| } | ||
| case .data(let data): | ||
| print("Got data back \(data)") | ||
| case .failed(let error): | ||
| XCTFail("Got error \(error)") | ||
| } | ||
| } | ||
| subscriptions.append(subscription) | ||
| } | ||
|
|
||
| wait(for: [subscribeSuccess], timeout: TestCommonConstants.networkTimeout) | ||
| XCTAssertEqual(subscriptions.count, 100) | ||
| let limitExceeded = expectation(description: "Received Limit Exceeded error") | ||
| limitExceeded.expectedFulfillmentCount = 2 | ||
| for _ in 1 ... 2 { | ||
| let subscription = AppSyncSubscriptionConnection(provider: connectionProvider) | ||
| subscription.addRetryHandler(handler: TestConnectionRetryHandler()) | ||
| _ = subscription.subscribe( | ||
| requestString: requestString, | ||
| variables: nil | ||
| ) { event, _ in | ||
| switch event { | ||
| case .connection(let subscriptionConnectionEvent): | ||
| switch subscriptionConnectionEvent { | ||
| case .connecting: | ||
| break | ||
| case .connected: | ||
| XCTFail("Got connected successfully - Should have been limit exceeded") | ||
| case .disconnected: | ||
| break | ||
| } | ||
| case .data(let data): | ||
| print("Got data back \(data)") | ||
| case .failed(let error): | ||
| guard let connectionError = error as? ConnectionProviderError, | ||
| case .limitExceeded = connectionError else { | ||
| XCTFail("Should Be Limited Exceeded error") | ||
| return | ||
| } | ||
|
|
||
| limitExceeded.fulfill() | ||
| } | ||
| } | ||
| subscriptions.append(subscription) | ||
| } | ||
|
|
||
| wait(for: [limitExceeded], timeout: TestCommonConstants.networkTimeout) | ||
|
|
||
| for subscription in subscriptions { | ||
| if let item = subscription.subscriptionItem { | ||
| subscription.unsubscribe(item: item) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| class TestConnectionRetryHandler: ConnectionRetryHandler { | ||
| var count: Int = 0 | ||
| func shouldRetryRequest(for error: ConnectionProviderError) -> RetryAdvice { | ||
| if count > 10 { | ||
| return TestRetryAdvice(shouldRetry: false) | ||
| } | ||
|
|
||
| if case .limitExceeded = error { | ||
| self.count += 1 | ||
| return TestRetryAdvice(shouldRetry: true, retryInterval: .seconds(1)) | ||
| } | ||
| return TestRetryAdvice(shouldRetry: false) | ||
|
|
||
| } | ||
| } | ||
|
|
||
| struct TestRetryAdvice: RetryAdvice { | ||
| var shouldRetry: Bool | ||
|
|
||
| var retryInterval: DispatchTimeInterval? | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters