Socket Disconnect when no remaining subscriptions #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawmicha
changed the title
lawmicha
force-pushed
the
feature/socket-disconnect
branch
2 times, most recently
from
ba30fc3 to
a9c0391
Compare
lawmicha
force-pushed
the
feature/socket-disconnect
branch
from
a9c0391 to
17c3b81
Compare
royjit
reviewed
Mar 23, 2020
| guard let self = self else { | ||
| return | ||
| } | ||
| self.status = .notConnected |
There was a problem hiding this comment.
Shouldnt we check the number of connections here before sending disconnect to the websocket?
There was a problem hiding this comment.
woops, missed this after moving implemenentions back and forth
royjit
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a timeout to disconnect the websocket when there are no remaining subscriptions
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.