Skip to content

Commit

Permalink
Read version number from build instead of hardcoding it (#3412)
Browse files Browse the repository at this point in the history
* Read version number from build instead of hardcoding it

* Also re-enable build config

* Fix test

* empty commit to retrigger tests

---------

Co-authored-by: Thomas Leing <leint@amazon.com>
  • Loading branch information
tjleing and Thomas Leing authored Oct 20, 2023
1 parent 9134f0b commit a002409
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

package com.amazonaws.util;

import com.amazonaws.BuildConfig;
import com.amazonaws.logging.Log;
import com.amazonaws.logging.LogFactory;

Expand All @@ -26,7 +27,7 @@ public class VersionInfoUtils {
private static final int DEFAULT_STRING_LENGTH = 128;

/** SDK version info */
private static volatile String version = "2.22.6";
private static volatile String version = BuildConfig.VERSION_NAME;
// changed build
// logic

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

package com.amazonaws.util;

import com.amazonaws.BuildConfig;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;

Expand All @@ -24,7 +25,7 @@ public class VersionInfoUtilsTest {

@Test
public void getVersion() {
assertEquals("2.22.6", VersionInfoUtils.getVersion());
assertEquals(BuildConfig.VERSION_NAME, VersionInfoUtils.getVersion());
}

@Test
Expand Down
1 change: 0 additions & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ org.gradle.jvmargs=-Xmx1536m

# Disable Gradle Android plugin features.
# Reference: https://developer.android.com/studio/releases/gradle-plugin#4-0-0-new
android.defaults.buildfeatures.buildconfig=false
android.defaults.buildfeatures.aidl=false
android.defaults.buildfeatures.renderscript=false
android.defaults.buildfeatures.resvalues=false
Expand Down

0 comments on commit a002409

Please sign in to comment.