Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWSlotMqttManager offlinePublishQueueBound not working #2558

Closed
tomashavlicek opened this issue Aug 3, 2021 · 3 comments
Closed

AWSlotMqttManager offlinePublishQueueBound not working #2558

tomashavlicek opened this issue Aug 3, 2021 · 3 comments
Assignees
@raphkim
Labels
bug Something isn't working iot Issues with the AWS Android SDK for Internet of Things (IoT) pending-release Code has been merged but pending release

Comments

@tomashavlicek
Copy link

tomashavlicek commented Aug 3, 2021 •
edited
Loading

Describe the bug
The offlinePublishQueueBound in the AWSlotMqttManager fails to apply an actual message limit. In the method putMessageInQueueAndNotify is called mqttMessageQueue.remove(0); which intends to remove first item of a queue, however ConcurentLinkedQueue.remove accepts only an Object of given queue as a parameter. This results into the remove call never removing items.

Which AWS service(s) are affected?
aws-android-sdk-iot
@tomashavlicek tomashavlicek mentioned this issue Aug 3, 2021
Closed
@raphkim raphkim added bug Something isn't working iot Issues with the AWS Android SDK for Internet of Things (IoT) labels Aug 4, 2021
@raphkim raphkim mentioned this issue Aug 4, 2021
Merged
@raphkim
Copy link
Contributor

raphkim commented Aug 4, 2021

Thank you for catching this issue @CapitainOats! I have a PR to address the bug and we will close the issue once it is released.

@raphkim raphkim added the pending-release Code has been merged but pending release label Aug 4, 2021
@raphkim raphkim self-assigned this Aug 4, 2021
@tomashavlicek
Copy link
Author

@raphkim Thanks for the fast response. I closed the duplicated PR #2559 created by me.

@div5yesh
Copy link
Contributor

The fix is released in v2.28.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raphkim raphkim

Labels
bug Something isn't working iot Issues with the AWS Android SDK for Internet of Things (IoT) pending-release Code has been merged but pending release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@div5yesh @tomashavlicek @raphkim