Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-android-sdk-iot): fix message queue not respecting size limit #2565

Merged
merged 5 commits into from
Aug 6, 2021

Conversation

raphkim
Copy link
Contributor

@raphkim raphkim commented Aug 4, 2021

Issue #, if available:
#2558
Description of changes:
Old logic: remove 0 from message queue if full
Fixed logic: remove 0th item from message queue if full

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@raphkim raphkim requested a review from a team August 4, 2021 22:21
@lgtm-com
Copy link

lgtm-com bot commented Aug 4, 2021

This pull request fixes 1 alert when merging ff79988 into 1940e05 - view on LGTM.com

fixed alerts:

  • 1 for Type mismatch on container modification

@poojamat
Copy link
Contributor

poojamat commented Aug 6, 2021

Good catch!

@poojamat poojamat closed this Aug 6, 2021
Copy link
Contributor

@sdhuka sdhuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@poojamat poojamat reopened this Aug 6, 2021
@lgtm-com
Copy link

lgtm-com bot commented Aug 6, 2021

This pull request fixes 1 alert when merging c2141f6 into 4341db0 - view on LGTM.com

fixed alerts:

  • 1 for Type mismatch on container modification

@lgtm-com
Copy link

lgtm-com bot commented Aug 6, 2021

This pull request fixes 1 alert when merging bb63d1d into b182ac2 - view on LGTM.com

fixed alerts:

  • 1 for Type mismatch on container modification

@raphkim raphkim merged commit b349abe into aws-amplify:main Aug 6, 2021
@raphkim raphkim deleted the fix-2558 branch August 6, 2021 21:30
@lgtm-com
Copy link

lgtm-com bot commented Aug 6, 2021

This pull request fixes 1 alert when merging 43b736e into b182ac2 - view on LGTM.com

fixed alerts:

  • 1 for Type mismatch on container modification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants