Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tagging for multipart upload #1138

Merged
merged 6 commits into from
Aug 20, 2019

Conversation

raphkim
Copy link
Contributor

@raphkim raphkim commented Aug 19, 2019

Issue #, if available:
#541

Description of changes:
Added tagging to initiateMultipartUploadRequest and to HTTP request header.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@raphkim raphkim added Pull Request s3 Issues with the AWS Android SDK for Simple Storage Service (S3). labels Aug 19, 2019
@raphkim raphkim changed the title Issue#541 Fix tagging for multipart upload Aug 19, 2019
@mutablealligator
Copy link
Contributor

@raphkim Add changelog statement.

@mutablealligator mutablealligator self-assigned this Aug 19, 2019
@mutablealligator mutablealligator merged commit ef01d9b into aws-amplify:develop Aug 20, 2019
@raphkim raphkim deleted the issue#541 branch August 22, 2019 19:27
awsmobilesdk pushed a commit to awsmobilesdk/aws-sdk-android that referenced this pull request Apr 12, 2020
* Added integration test for object tagging

* Fixed bug where multipart upload fails to append tag

* Added javadoc and added timeout to integration test

* Updated CHANGELOG.md

* Minor updates to CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s3 Issues with the AWS Android SDK for Simple Storage Service (S3).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants