Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-android-sdk-mobile-client): fix NPE in hosted UI options #2564

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

raphkim
Copy link
Contributor

@raphkim raphkim commented Aug 4, 2021

Issue #, if available:
#2560
Description of changes:
Null-check was being performed on an irrelevant field, causing an NPE in certain situations. Now checks for null in correct field.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@raphkim raphkim requested a review from a team August 4, 2021 22:13
Copy link
Contributor

@sdhuka sdhuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raphkim raphkim merged commit 61a1e78 into aws-amplify:main Aug 5, 2021
@raphkim raphkim deleted the fix-2560 branch August 5, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants